Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflowing Content visible when flex item is added to markup.html without container #152

Closed
craigpryde opened this issue Jan 8, 2018 · 1 comment
Labels

Comments

@craigpryde
Copy link
Contributor

craigpryde commented Jan 8, 2018

Tell us about the issue you are experiencing

When adding an element to the style guide that is mostly flexbox based without a container. The content spills onto the Introduction page as the pre-loaded content wrapper cant contain the flex items.

How can this issue be replicated?

Add Multiple items to Astrum markup.html files that contain wrappers that are flex based.

Screenshots / Screencast

image

image

Your environment

Platform: MAC (Chrome -> Latest Release & Canary)
OS Version: Latest High Sierra
Node Version: v8.9.1
NPM Version: Using Yarn 1.3.2
Astrum Version: v1.9.5


Hey folks,

Loving the style guide and currently using it for one of our projects. I have however found a weird bug when I add a bunch of components to the style guide that contain flex based items. The preload wrapper seems to be overflowing the content loaded onto the introduction page hich creates the above issue in the screenshot.

I've managed to fix this by adding the following CSS to the preload container:

    .ndpl-preloaded {
        display: table;
        overflow: hidden;
    }

This seems to fix the overflow and contain the preloaded content without affecting the style guide components when selected:
image

image

Let me know your thoughts, I'll attach a pull request to the ticket tonight.

Keep up the great work!

Cheers

Craig

@Andy-set-studio
Copy link
Contributor

Resolved with #153. Thanks for your help @craigpryde!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants