-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat!: Stop supporting console.log selectors with "(u)int" aliases
Historically, Hardhat used selectors that computed signatures such as "log(int)", "log(bool,int)", even though the canonical ABI spec defines that the keccak256 should be calculated over the canonical type name, so "int256" or "uint256". This change removes this support as popular tools already support the correct ABI encoding or patch the faulty one, instead.
- Loading branch information
Showing
3 changed files
with
5 additions
and
233 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"hardhat": minor | ||
--- | ||
|
||
Remove support for `console.log` selectors that wrongly use "(u)int" type aliases in the selector calculation |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.