Merge pull request #3178 from NomicFoundation/show-stack-traces-on-cis

Always show stack traces on CI servers
NomicFoundation · Sep 14, 2022 · acb5365 · acb5365
2 parents 061050a + 1093aa4
commit acb5365
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/.changeset/stale-paws-breathe.md b/.changeset/stale-paws-breathe.md
@@ -0,0 +1,5 @@
+---
+"hardhat": patch
+---
+
+Always show stack traces on CI servers
diff --git a/packages/hardhat-core/src/internal/cli/cli.ts b/packages/hardhat-core/src/internal/cli/cli.ts
@@ -50,6 +50,7 @@ import {
 const log = debug("hardhat:core:cli");
 
 const ANALYTICS_SLOW_TASK_THRESHOLD = 300;
+const SHOULD_SHOW_STACK_TRACES_BY_DEFAULT = isRunningOnCiServer();
 
 async function printVersionMessage(packageJson: PackageJson) {
   console.log(packageJson.version);
@@ -106,7 +107,9 @@ async function suggestInstallingHardhatVscode() {
 async function main() {
   // We first accept this argument anywhere, so we know if the user wants
   // stack traces before really parsing the arguments.
-  let showStackTraces = process.argv.includes("--show-stack-traces");
+  let showStackTraces =
+    process.argv.includes("--show-stack-traces") ||
+    SHOULD_SHOW_STACK_TRACES_BY_DEFAULT;
 
   try {
     const packageJson = await getPackageJson();
@@ -328,7 +331,7 @@ async function main() {
       log("Couldn't report error to sentry: %O", e);
     }
 
-    if (showStackTraces) {
+    if (showStackTraces || SHOULD_SHOW_STACK_TRACES_BY_DEFAULT) {
       console.error(error);
     } else {
       if (!isHardhatError) {

diff --git a/packages/hardhat-core/src/internal/core/params/hardhat-params.ts b/packages/hardhat-core/src/internal/core/params/hardhat-params.ts
@@ -15,7 +15,7 @@ export const HARDHAT_PARAM_DEFINITIONS: HardhatParamDefinitions = {
   showStackTraces: {
     name: "showStackTraces",
     defaultValue: false,
-    description: "Show stack traces.",
+    description: "Show stack traces (always enabled on CI servers).",
     type: types.boolean,
     isFlag: true,
     isOptional: true,

diff --git a/packages/hardhat-core/test/internal/cli/autocomplete.ts b/packages/hardhat-core/test/internal/cli/autocomplete.ts
@@ -83,7 +83,7 @@ const coreParams = [
     name: "--network",
   },
   {
-    description: "Show stack traces.",
+    description: "Show stack traces (always enabled on CI servers).",
     name: "--show-stack-traces",
   },
   versionParam,