-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to make user defined network config url property optional #3221
Comments
This issue is also being tracked on Linear. We use Linear to manage our development process, but we keep the conversations on Github. LINEAR-ID: 0c6d7400-3e62-4ca4-b055-f80075961d3d |
I don't think this is doable right now. Maybe we could move that validation after the config is resolved, and that way you could put some dummy urls with
Can you expand on this? |
Yes, If validation happens after config is resolved, providing an empty string inside
On our custom network, |
That's very interesting. @alcuadrado what do you think about moving the |
Any updates? |
Hi @Nathan-SL, sorry for not responding before. We decided to go on with that approach. I opened #3323 to track that effort, so I'm going to close this one in favor of that. |
We're building a hardhat plugin. How should the plugin be written so that custom networks can omit the url property? Currently, user-defined network configs don't allow omitting the
url
property and for some special cases, it seems reasonable to have a way to support it as an optional property. Here's the error we get from the validator.For a config file like below.
The text was updated successfully, but these errors were encountered: