Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a validation phase for the resolved configuration #3500

Closed
fvictorio opened this issue Dec 30, 2022 · 0 comments · Fixed by #3512
Closed

Add a validation phase for the resolved configuration #3500

fvictorio opened this issue Dec 30, 2022 · 0 comments · Fixed by #3512
Labels
good-first-issue Good for newcomers. Guidance available if needed status:ready This issue is ready to be worked on type:improvement

Comments

@fvictorio
Copy link
Member

We validate the values provider in the user config, but not the ones that result after resolving the configuration (using our resolution and the config extenders). This is a blocker for #3323 and makes #3488 harder to do.

We should add something like validateResolvedConfig(resolved) after this:

for (const extender of HardhatContext.getHardhatContext().configExtenders) {
extender(resolved, frozenUserConfig);
}

Validating the number of optimizer runs (#3488) is easy and low risk, so maybe that could be the first validation included there.

@fvictorio fvictorio added good-first-issue Good for newcomers. Guidance available if needed type:improvement status:ready This issue is ready to be worked on labels Dec 30, 2022
@github-project-automation github-project-automation bot moved this to Done in Hardhat Jan 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good-first-issue Good for newcomers. Guidance available if needed status:ready This issue is ready to be worked on type:improvement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant