-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop recursive validity checks for nodes #1005
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We query for node completeness/correctness recursively during parsing, for both valid and invalid inputs. For example
Match::is_full_recursive()
, which will happen for anyChoiceHelper
even at root of the tree (likeSourceUnitMember
). There could be other places as well that create aCursor
during parsing do check for sub-trees recursively.We should revisit this once #808 is complete.
One solution is to track this information via a field on the
ParserResult
instead, and propagate that field upwards instead.The text was updated successfully, but these errors were encountered: