From db1e996e575cb51541de46aa3df01eb0782f1d15 Mon Sep 17 00:00:00 2001
From: ultranity <zjy1095429904@sina.com>
Date: Sun, 26 Apr 2020 14:29:57 +0800
Subject: [PATCH 1/5] add feature: hide bookmarked pictures (in user detail
 page)

---
 .../perol/asdpl/pixivez/activity/UserMActivity.kt    |  5 +++++
 .../perol/asdpl/pixivez/adapters/RecommendAdapter.kt | 12 ++++++++++--
 .../pixivez/adapters/viewpager/UserMPagerAdapter.kt  |  6 +++++-
 .../asdpl/pixivez/fragments/UserIllustFragment.kt    |  6 +++++-
 .../perol/asdpl/pixivez/viewmodel/UserMViewModel.kt  |  1 +
 app/src/main/res/menu/menu_userx.xml                 |  7 ++++++-
 app/src/main/res/values-en/strings.xml               |  1 +
 app/src/main/res/values-zh-rTW/strings.xml           |  1 +
 app/src/main/res/values/strings.xml                  |  7 ++++---
 9 files changed, 38 insertions(+), 8 deletions(-)

diff --git a/app/src/main/java/com/perol/asdpl/pixivez/activity/UserMActivity.kt b/app/src/main/java/com/perol/asdpl/pixivez/activity/UserMActivity.kt
index bbc7525..01018fc 100644
--- a/app/src/main/java/com/perol/asdpl/pixivez/activity/UserMActivity.kt
+++ b/app/src/main/java/com/perol/asdpl/pixivez/activity/UserMActivity.kt
@@ -237,6 +237,11 @@ class UserMActivity : RinkActivity() {
         when (item.itemId) {
             android.R.id.home -> finishAfterTransition()
             R.id.action_share -> share()
+            R.id.action_hideBookmarked -> {
+                viewModel.hideBookmarked.value = !viewModel.hideBookmarked.value!!
+                item.isChecked = !item.isChecked
+                mviewpager.adapter?.notifyDataSetChanged()
+            }
             R.id.action_download -> {
 //                val intent =Intent(this,WorkActivity::class.java)
 //                intent.putExtra("id",id)
diff --git a/app/src/main/java/com/perol/asdpl/pixivez/adapters/RecommendAdapter.kt b/app/src/main/java/com/perol/asdpl/pixivez/adapters/RecommendAdapter.kt
index fd11d48..5546468 100644
--- a/app/src/main/java/com/perol/asdpl/pixivez/adapters/RecommendAdapter.kt
+++ b/app/src/main/java/com/perol/asdpl/pixivez/adapters/RecommendAdapter.kt
@@ -62,7 +62,8 @@ class RecommendAdapter(
     layoutResId: Int,
     data: List<Illust>?,
     private val R18on: Boolean,
-    var blockTags: List<String>
+    var blockTags: List<String>,
+    var hideBookmarked: Boolean = false
 ) :
     BaseQuickAdapter<Illust, BaseViewHolder>(layoutResId, data?.toMutableList()), LoadMoreModule {
 
@@ -131,7 +132,14 @@ class RecommendAdapter(
                 break
             }
         }
-
+        if (hideBookmarked && item.is_bookmarked){
+            helper.itemView.visibility = View.GONE
+            helper.itemView.layoutParams.apply {
+                height = 0
+                width = 0
+            }
+            return
+        }
         if (blockTags.isNotEmpty() && tags.isNotEmpty() && needBlock) {
             helper.itemView.visibility = View.GONE
             helper.itemView.layoutParams.apply {
diff --git a/app/src/main/java/com/perol/asdpl/pixivez/adapters/viewpager/UserMPagerAdapter.kt b/app/src/main/java/com/perol/asdpl/pixivez/adapters/viewpager/UserMPagerAdapter.kt
index 78f70d1..25aa1ce 100644
--- a/app/src/main/java/com/perol/asdpl/pixivez/adapters/viewpager/UserMPagerAdapter.kt
+++ b/app/src/main/java/com/perol/asdpl/pixivez/adapters/viewpager/UserMPagerAdapter.kt
@@ -39,7 +39,11 @@ class UserMPagerAdapter(
     var newInstance: Fragment
 ) : FragmentStatePagerAdapter(fm, BEHAVIOR_RESUME_ONLY_CURRENT_FRAGMENT) {
 
-
+    override fun getItemPosition(`object`: Any): Int {
+        return if (`object`.javaClass.name == "com.perol.asdpl.pixivez.fragments.UserIllustFragment") {
+            FragmentStatePagerAdapter.POSITION_NONE
+        } else super.getItemPosition(`object`)
+    }
 /*    override fun getItemCount() = 4
 
     override fun createFragment(position: Int) = when (position) {
diff --git a/app/src/main/java/com/perol/asdpl/pixivez/fragments/UserIllustFragment.kt b/app/src/main/java/com/perol/asdpl/pixivez/fragments/UserIllustFragment.kt
index 8a60a28..d255508 100644
--- a/app/src/main/java/com/perol/asdpl/pixivez/fragments/UserIllustFragment.kt
+++ b/app/src/main/java/com/perol/asdpl/pixivez/fragments/UserIllustFragment.kt
@@ -27,6 +27,7 @@ package com.perol.asdpl.pixivez.fragments
 
 import android.os.Bundle
 import android.view.LayoutInflater
+import android.view.Menu
 import android.view.View
 import android.view.ViewGroup
 import androidx.fragment.app.Fragment
@@ -34,6 +35,7 @@ import androidx.lifecycle.Observer
 import androidx.lifecycle.ViewModelProvider
 import androidx.recyclerview.widget.StaggeredGridLayoutManager
 import com.perol.asdpl.pixivez.R
+import com.perol.asdpl.pixivez.activity.UserMActivity
 import com.perol.asdpl.pixivez.adapters.RecommendAdapter
 import com.perol.asdpl.pixivez.objects.AdapterRefreshEvent
 import com.perol.asdpl.pixivez.objects.BaseFragment
@@ -81,6 +83,7 @@ class UserIllustFragment : BaseFragment() {
         mrecyclerview.layoutManager =
             StaggeredGridLayoutManager(2, StaggeredGridLayoutManager.VERTICAL)
         mrecyclerview.adapter = recommendAdapter
+        recommendAdapter.hideBookmarked = viewactivity.viewModel.hideBookmarked.value!!
     }
 
     // TODO: Rename and change types of parameters
@@ -102,6 +105,7 @@ class UserIllustFragment : BaseFragment() {
                 recommendAdapter.loadMoreComplete()
             }
         })
+        viewactivity = activity as UserMActivity
         viewmodel.data.observe(this, Observer {
             if (it != null) {
                 mrefreshlayout.isRefreshing = false
@@ -123,7 +127,7 @@ class UserIllustFragment : BaseFragment() {
     }
 
     lateinit var viewmodel: UserMillustViewModel
-
+    lateinit var viewactivity: UserMActivity
 
     lateinit var recommendAdapter: RecommendAdapter
     override fun onCreateView(
diff --git a/app/src/main/java/com/perol/asdpl/pixivez/viewmodel/UserMViewModel.kt b/app/src/main/java/com/perol/asdpl/pixivez/viewmodel/UserMViewModel.kt
index 7084fb1..9849d0b 100644
--- a/app/src/main/java/com/perol/asdpl/pixivez/viewmodel/UserMViewModel.kt
+++ b/app/src/main/java/com/perol/asdpl/pixivez/viewmodel/UserMViewModel.kt
@@ -40,6 +40,7 @@ class UserMViewModel : BaseViewModel() {
     var retrofitRespository = RetrofitRepository.getInstance()
     var userDetail = MutableLiveData<UserDetailResponse>()
     var isfollow = MutableLiveData<Boolean>()
+    var hideBookmarked = MutableLiveData<Boolean>(false)
 
     fun getData(userid: Long) {
         retrofitRespository.getUserDetail(userid).subscribe({
diff --git a/app/src/main/res/menu/menu_userx.xml b/app/src/main/res/menu/menu_userx.xml
index 136c5fd..6e70557 100644
--- a/app/src/main/res/menu/menu_userx.xml
+++ b/app/src/main/res/menu/menu_userx.xml
@@ -7,9 +7,14 @@
     <item
         android:id="@+id/action_share"
         android:icon="@drawable/ic_action_share"
-        app:iconTint="?android:textColorPrimaryInverse"
         android:title="share"
+        app:iconTint="?android:textColorPrimaryInverse"
         app:showAsAction="ifRoom" />
+    <item
+        android:id="@+id/action_hideBookmarked"
+        android:checkable="true"
+        android:title="@string/hide_bookmarked"
+        app:showAsAction="collapseActionView" />
     <item
         android:id="@+id/action_download"
         android:title="Σ( ° △ °|||)︴"
diff --git a/app/src/main/res/values-en/strings.xml b/app/src/main/res/values-en/strings.xml
index c5a6e4d..b016274 100644
--- a/app/src/main/res/values-en/strings.xml
+++ b/app/src/main/res/values-en/strings.xml
@@ -251,6 +251,7 @@
     <string name="start_date">Start Date</string>
     <string name="end_date">End Date</string>
     <string name="choice_date">Choice Date</string>
+    <string name="hide_bookmarked">Hide Bookmarked Pic</string>
     <string name="create_painter_folder">Create a separate folder for each painter</string>
     <string name="create_separate_folder">create separate folder</string>
     <string name="refresh_token">refresh token</string>
diff --git a/app/src/main/res/values-zh-rTW/strings.xml b/app/src/main/res/values-zh-rTW/strings.xml
index a31493c..1561d75 100644
--- a/app/src/main/res/values-zh-rTW/strings.xml
+++ b/app/src/main/res/values-zh-rTW/strings.xml
@@ -266,6 +266,7 @@
     <string name="start_date">Start Date</string>
     <string name="end_date">End Date</string>
     <string name="choice_date">Choice Date</string>
+    <string name="hide_bookmarked">隐藏已收藏圖像</string>
     <string name="create_painter_folder">為每個繪師單獨建立資料夾</string>
     <string name="create_separate_folder">create separate folder</string>
     <string name="refresh_token">重新載入 token</string>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 846a96d..d3e6a78 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -279,9 +279,10 @@
     <string name="unlimit">不限</string>
     <string name="bookmark_private">悄悄收藏</string>
     <string name="bookmark_public">公开收藏</string>
-    <string name="start_date">Start Date</string>
-    <string name="end_date">End Date</string>
-    <string name="choice_date">Choice Date</string>
+    <string name="start_date">开始日期</string>
+    <string name="end_date">结束日期</string>
+    <string name="choice_date">选择时间段</string>
+    <string name="hide_bookmarked">隐藏已收藏图片</string>
     <string name="summary">在刚接触JAVA的时候边学官方文档边做,摸索着完成了这个客户端,因为个人能力的问题,出过不少丢人的BUG,优化问题,在完善这个应用的过程中，我获得了很多的开发经验与比较深刻的教训，也得到了很多人的帮助和支持</string>
     <string name="title_change_theme">更换主题</string>
     <string name="title_save_path">保存路径</string>

From 406e0ca96478260af58f64618b3533baf2d30ac2 Mon Sep 17 00:00:00 2001
From: ultranity <zjy1095429904@sina.com>
Date: Sun, 26 Apr 2020 14:39:46 +0800
Subject: [PATCH 2/5] add feature: hide bookmarked pictures (in search page)

---
 .../pixivez/dialog/SearchSectionDialog.kt     |  7 ++
 .../asdpl/pixivez/fragments/IllustFragment.kt | 18 +++--
 .../viewmodel/IllustfragmentViewModel.kt      |  1 +
 .../main/res/layout/dialog_searchsection.xml  | 79 +++++++++++++++----
 4 files changed, 81 insertions(+), 24 deletions(-)

diff --git a/app/src/main/java/com/perol/asdpl/pixivez/dialog/SearchSectionDialog.kt b/app/src/main/java/com/perol/asdpl/pixivez/dialog/SearchSectionDialog.kt
index 52231b5..c01c5dc 100644
--- a/app/src/main/java/com/perol/asdpl/pixivez/dialog/SearchSectionDialog.kt
+++ b/app/src/main/java/com/perol/asdpl/pixivez/dialog/SearchSectionDialog.kt
@@ -108,6 +108,13 @@ class SearchSectionDialog : DialogFragment() {
             }
             isChecked = viewModel.endDate.value != null && viewModel.startDate.value != null
 
+        }
+        val toggleShow= view.findViewById<ToggleButton>(R.id.toggleShow).apply {
+            setOnCheckedChangeListener { buttonView, isChecked ->
+                viewModel.hideBookmarked.value = isChecked
+            }
+            isChecked = viewModel.hideBookmarked.value == true
+
         }
         val button = view.findViewById<Button>(R.id.pick_button).apply {
             var calendar = Calendar.getInstance()
diff --git a/app/src/main/java/com/perol/asdpl/pixivez/fragments/IllustFragment.kt b/app/src/main/java/com/perol/asdpl/pixivez/fragments/IllustFragment.kt
index b1d4356..f1e9f04 100644
--- a/app/src/main/java/com/perol/asdpl/pixivez/fragments/IllustFragment.kt
+++ b/app/src/main/java/com/perol/asdpl/pixivez/fragments/IllustFragment.kt
@@ -207,14 +207,14 @@ class IllustFragment : BaseFragment(), AdapterView.OnItemSelectedListener {
         }*/
         requireActivity().findViewById<TabLayout>(R.id.tablayout_searchresult)?.getTabAt(0)
             ?.view?.setOnClickListener {
-            if ((System.currentTimeMillis() - exitTime) > 3000) {
+                if ((System.currentTimeMillis() - exitTime) > 3000) {
 
-                exitTime = System.currentTimeMillis()
-            } else {
-                recyclerview_illust.smoothScrollToPosition(0)
-            }
+                    exitTime = System.currentTimeMillis()
+                } else {
+                    recyclerview_illust.smoothScrollToPosition(0)
+                }
 
-        }
+            }
     }
 
     private val starnum = intArrayOf(50000, 30000, 20000, 10000, 5000, 1000, 500, 250, 100, 0)
@@ -275,7 +275,11 @@ class IllustFragment : BaseFragment(), AdapterView.OnItemSelectedListener {
         viewModel.isRefresh.observe(this, Observer {
             swiperefresh.isRefreshing = it
         })
-
+        viewModel.hideBookmarked.observe(this, Observer {
+            if (it != null) {
+                searchIllustAdapter.hideBookmarked = it
+            }
+        })
     }
 
     private fun addIllust(it: java.util.ArrayList<Illust>) {
diff --git a/app/src/main/java/com/perol/asdpl/pixivez/viewmodel/IllustfragmentViewModel.kt b/app/src/main/java/com/perol/asdpl/pixivez/viewmodel/IllustfragmentViewModel.kt
index 1fed6b6..00c7d73 100644
--- a/app/src/main/java/com/perol/asdpl/pixivez/viewmodel/IllustfragmentViewModel.kt
+++ b/app/src/main/java/com/perol/asdpl/pixivez/viewmodel/IllustfragmentViewModel.kt
@@ -48,6 +48,7 @@ class IllustfragmentViewModel : BaseViewModel() {
     var nexturl = MutableLiveData<String>()
     var bookmarkid = MutableLiveData<Long>()
     var isRefresh = MutableLiveData<Boolean>(false)
+    var hideBookmarked = MutableLiveData<Boolean>(false)
     val sort = MutableLiveData<String>(sortT[0])
     val searchTarget = MutableLiveData<String>(search_targetT[0])
     val startDate = MutableLiveData<Calendar>()
diff --git a/app/src/main/res/layout/dialog_searchsection.xml b/app/src/main/res/layout/dialog_searchsection.xml
index 1310f4c..5da87ac 100644
--- a/app/src/main/res/layout/dialog_searchsection.xml
+++ b/app/src/main/res/layout/dialog_searchsection.xml
@@ -132,24 +132,69 @@
                android:layout_height="match_parent"
                android:text="@string/a_year" />
        </com.google.android.material.tabs.TabLayout>-->
-    <TextView
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:layout_gravity="center"
-        android:layout_marginStart="8dp"
-        android:layout_marginTop="5dp"
-        android:layout_marginEnd="8dp"
-        android:text="@string/choice_date"
-        android:textSize="16sp" />
 
-    <ToggleButton
-        android:id="@+id/toggle"
-        android:layout_margin="8dp"
-        android:layout_width="wrap_content"
-        android:contentDescription="@string/choice"
-        android:checked="false"
-        android:text="@string/choice_date"
-        android:layout_height="wrap_content" />
+    <TableLayout
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content">
+
+        <TableRow
+            android:layout_width="match_parent"
+            android:layout_height="match_parent" >
+
+            <TextView
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:layout_gravity="center"
+                android:layout_marginStart="8dp"
+                android:layout_marginTop="5dp"
+                android:layout_marginEnd="8dp"
+                android:text="@string/choice_date"
+                android:textSize="16sp" />
+
+            <Space
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:layout_weight="1" />
+
+            <TextView
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:layout_gravity="center"
+                android:layout_marginStart="8dp"
+                android:layout_marginTop="5dp"
+                android:layout_marginEnd="8dp"
+                android:text="@string/hide_bookmarked"
+                android:textSize="16sp" />
+        </TableRow>
+
+        <TableRow
+            android:layout_width="match_parent"
+            android:layout_height="match_parent" >
+
+            <ToggleButton
+                android:id="@+id/toggle"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:layout_margin="8dp"
+                android:checked="false"
+                android:contentDescription="@string/choice"
+                android:text="@string/choice_date" />
+
+            <Space
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:layout_weight="1" />
+
+            <ToggleButton
+                android:id="@+id/toggleShow"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:layout_margin="8dp"
+                android:checked="false"
+                android:text="@string/hide_bookmarked" />
+        </TableRow>
+
+    </TableLayout>
 
     <LinearLayout
         android:id="@+id/pick_date_layout"

From 53b0f14f1e0a680551675807bc4d43596f00de3e Mon Sep 17 00:00:00 2001
From: elucida <1095429904@qq.com>
Date: Sun, 26 Apr 2020 20:25:20 +0800
Subject: [PATCH 3/5] delete cache after success instantly

file.delete()
---
 app/src/main/java/com/perol/asdpl/pixivez/services/Works.kt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/com/perol/asdpl/pixivez/services/Works.kt b/app/src/main/java/com/perol/asdpl/pixivez/services/Works.kt
index 899389c..f5a4f74 100644
--- a/app/src/main/java/com/perol/asdpl/pixivez/services/Works.kt
+++ b/app/src/main/java/com/perol/asdpl/pixivez/services/Works.kt
@@ -117,9 +117,10 @@ object Works {
         val targetFile = File(path, filename)
         try {
             file.copyTo(targetFile, overwrite = true)
+            file.delete()
             Toasty.success(
                 PxEZApp.instance,
-                PxEZApp.instance.resources.getString(R.string.savesuccess),
+                PxEZApp.instance.resources.getString(R.string.savesuccess)+"!",
                 Toast.LENGTH_SHORT
             ).show()
             MediaScannerConnection.scanFile(
@@ -134,7 +135,6 @@ object Works {
         } catch (e: Exception) {
 
         }
-
     }
 
     fun imageDownloadAll(illust: Illust) {

From e9a054a7383a9cb547fce6a028ff237c88676874 Mon Sep 17 00:00:00 2001
From: elucida <1095429904@qq.com>
Date: Sun, 26 Apr 2020 20:26:06 +0800
Subject: [PATCH 4/5] delete cache after success instantly

file.delete()
---
 app/src/main/java/com/perol/asdpl/pixivez/services/PxEZApp.kt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/src/main/java/com/perol/asdpl/pixivez/services/PxEZApp.kt b/app/src/main/java/com/perol/asdpl/pixivez/services/PxEZApp.kt
index a7d8a9b..4204c77 100644
--- a/app/src/main/java/com/perol/asdpl/pixivez/services/PxEZApp.kt
+++ b/app/src/main/java/com/perol/asdpl/pixivez/services/PxEZApp.kt
@@ -78,6 +78,7 @@ class PxEZApp : Application() {
             ) { _, _ ->
 
             }
+            sourceFile.delete()
             Toasty.success(this, "${title}${getString(R.string.savesuccess)}", Toast.LENGTH_SHORT)
                 .show()
         }

From dfa007ff32fab401be50a305af891a67d10c3ce8 Mon Sep 17 00:00:00 2001
From: ultranity <zjy1095429904@sina.com>
Date: Mon, 27 Apr 2020 11:10:07 +0800
Subject: [PATCH 5/5] SearchSectionDialog fix: show current config

---
 .../pixivez/dialog/SearchSectionDialog.kt     | 21 ++++++++++++-------
 .../asdpl/pixivez/fragments/IllustFragment.kt |  4 ++--
 .../viewmodel/IllustfragmentViewModel.kt      | 10 ++++-----
 3 files changed, 20 insertions(+), 15 deletions(-)

diff --git a/app/src/main/java/com/perol/asdpl/pixivez/dialog/SearchSectionDialog.kt b/app/src/main/java/com/perol/asdpl/pixivez/dialog/SearchSectionDialog.kt
index c01c5dc..a2d4255 100644
--- a/app/src/main/java/com/perol/asdpl/pixivez/dialog/SearchSectionDialog.kt
+++ b/app/src/main/java/com/perol/asdpl/pixivez/dialog/SearchSectionDialog.kt
@@ -50,9 +50,7 @@ class SearchSectionDialog : DialogFragment() {
     val tms = Calendar.getInstance()
     val thisMonth01 = "${tms.get(Calendar.YEAR)}-${tms.get(Calendar.MONTH) + 1}-01"
     val halfYear01 = "${tms.get(Calendar.YEAR)}-${tms.get(Calendar.MONTH) + 1}-01"
-    var sort = arrayOf("date_desc", "date_asc", "popular_desc")
-    var search_target =
-        arrayOf("partial_match_for_tags", "exact_match_for_tags", "title_and_caption")
+
 
     override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
         val word = arguments?.getString("word", "")
@@ -64,8 +62,10 @@ class SearchSectionDialog : DialogFragment() {
         )
         val viewModel =
             ViewModelProviders.of(requireParentFragment()).get(IllustfragmentViewModel::class.java)
+        var searchTargeti = viewModel.searchTarget.value
         val first = view.findViewById<TabLayout>(R.id.tablayout_search_target).apply {
             clearOnTabSelectedListeners()
+            searchTargeti?.let { getTabAt(it)?.select() }
             addOnTabSelectedListener(object : TabLayout.OnTabSelectedListener {
                 override fun onTabReselected(tab: TabLayout.Tab?) {
 
@@ -76,13 +76,15 @@ class SearchSectionDialog : DialogFragment() {
                 }
 
                 override fun onTabSelected(tab: TabLayout.Tab) {
-                    viewModel.searchTarget.value = search_target[tab.position]
+                    searchTargeti = tab.position
                 }
             })
         }
+        var sorti = viewModel.sort.value
         val second = view.findViewById<TabLayout>(R.id.tablayout_sort)
             .apply {
                 clearOnTabSelectedListeners()
+                sorti?.let { getTabAt(it)?.select() }
                 addOnTabSelectedListener(object : TabLayout.OnTabSelectedListener {
                     override fun onTabReselected(tab: TabLayout.Tab?) {
 
@@ -93,7 +95,7 @@ class SearchSectionDialog : DialogFragment() {
                     }
 
                     override fun onTabSelected(tab: TabLayout.Tab) {
-                        viewModel.sort.value = sort[tab.position]
+                        sorti = tab.position
                     }
                 })
             }
@@ -109,12 +111,12 @@ class SearchSectionDialog : DialogFragment() {
             isChecked = viewModel.endDate.value != null && viewModel.startDate.value != null
 
         }
+        var hideBookmarked = viewModel.hideBookmarked.value
         val toggleShow= view.findViewById<ToggleButton>(R.id.toggleShow).apply {
+            isChecked = hideBookmarked == true
             setOnCheckedChangeListener { buttonView, isChecked ->
-                viewModel.hideBookmarked.value = isChecked
+                hideBookmarked = isChecked
             }
-            isChecked = viewModel.hideBookmarked.value == true
-
         }
         val button = view.findViewById<Button>(R.id.pick_button).apply {
             var calendar = Calendar.getInstance()
@@ -180,6 +182,9 @@ class SearchSectionDialog : DialogFragment() {
 
         }
         builder.setPositiveButton(android.R.string.ok) { p0, p1 ->
+            viewModel.hideBookmarked.value = hideBookmarked
+            viewModel.sort.value = sorti
+            viewModel.searchTarget.value = searchTargeti
             if (word != null)
                 viewModel.firstSetData(word)
         }
diff --git a/app/src/main/java/com/perol/asdpl/pixivez/fragments/IllustFragment.kt b/app/src/main/java/com/perol/asdpl/pixivez/fragments/IllustFragment.kt
index f1e9f04..329ed7b 100644
--- a/app/src/main/java/com/perol/asdpl/pixivez/fragments/IllustFragment.kt
+++ b/app/src/main/java/com/perol/asdpl/pixivez/fragments/IllustFragment.kt
@@ -92,13 +92,13 @@ class IllustFragment : BaseFragment(), AdapterView.OnItemSelectedListener {
                         Toasty.error(PxEZApp.instance, "not premium!").show()
                         viewModel.setPreview(param1!!, sort[position], null, null)
                     } else {
-                        viewModel.sort.value = sort[position]
+                        viewModel.sort.value = position
                         viewModel.firstSetData(param1!!)
                     }
 
                 }
             } else {
-                viewModel.sort.value = sort[position]
+                viewModel.sort.value = position
                 viewModel.firstSetData(param1!!)
             }
         }
diff --git a/app/src/main/java/com/perol/asdpl/pixivez/viewmodel/IllustfragmentViewModel.kt b/app/src/main/java/com/perol/asdpl/pixivez/viewmodel/IllustfragmentViewModel.kt
index 00c7d73..4f8e460 100644
--- a/app/src/main/java/com/perol/asdpl/pixivez/viewmodel/IllustfragmentViewModel.kt
+++ b/app/src/main/java/com/perol/asdpl/pixivez/viewmodel/IllustfragmentViewModel.kt
@@ -39,7 +39,7 @@ fun Calendar?.generateDateString(): String? {
 
 class IllustfragmentViewModel : BaseViewModel() {
     var sortT = arrayOf("date_desc", "date_asc", "popular_desc")
-    var search_targetT =
+    var searchTargetT =
         arrayOf("partial_match_for_tags", "exact_match_for_tags", "title_and_caption")
 
     var illusts = MutableLiveData<ArrayList<Illust>>()
@@ -49,8 +49,8 @@ class IllustfragmentViewModel : BaseViewModel() {
     var bookmarkid = MutableLiveData<Long>()
     var isRefresh = MutableLiveData<Boolean>(false)
     var hideBookmarked = MutableLiveData<Boolean>(false)
-    val sort = MutableLiveData<String>(sortT[0])
-    val searchTarget = MutableLiveData<String>(search_targetT[0])
+    val sort = MutableLiveData<Int>(0)
+    val searchTarget = MutableLiveData<Int>(0)
     val startDate = MutableLiveData<Calendar>()
     val endDate = MutableLiveData<Calendar>()
     fun setPreview(word: String, sort: String, search_target: String?, duration: String?) {
@@ -75,8 +75,8 @@ class IllustfragmentViewModel : BaseViewModel() {
 
         retrofitRespository.getSearchIllust(
             word,
-            sort.value!!,
-            searchTarget.value!!,
+            sortT[sort.value!!],
+            searchTargetT[searchTarget.value!!],
             startDate.value.generateDateString(),
             endDate.value.generateDateString(),
             null