Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contentFiles don't flow transitively even when explicitly specified , if there is a projectReference involved #6826

Open
rohit21agrawal opened this issue Apr 13, 2018 · 5 comments
Labels
Area:ContentFiles PackageReference contentFiles folder Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug
Milestone

Comments

@rohit21agrawal
Copy link
Contributor

rohit21agrawal commented Apr 13, 2018

If ProjectA references PackageA which references PackageB (with contentFiles), and all reference edges have PrivateAssets=none set on it, the contentFiles should flow to ProjectA. However, this is not the case.

UPDATE: turns out the scenario is this:

ProjectA -> ProjectB ->PackageB (with contentFiles)

ProjectA doesn't get contentFiles from PackageB.

@rohit21agrawal rohit21agrawal added Type:Bug Area:ContentFiles PackageReference contentFiles folder labels Apr 13, 2018
@rohit21agrawal rohit21agrawal added this to the Backlog milestone Apr 13, 2018
@jainaashish
Copy link

do you have include=all on PackageB dependency listed in PackageA nuspec file?

@rohit21agrawal
Copy link
Contributor Author

yes sir!

@nkolev92
Copy link
Member

@rohit21agrawal

I can't reproduce this with SDK csproj Package Reference.

Did you try this with old csproj PR?

@rohit21agrawal rohit21agrawal changed the title contentFiles don't flow transitively even when explicitly specified contentFiles don't flow transitively even when explicitly specified , if there is a projectReference involved Apr 16, 2018
@rohit21agrawal
Copy link
Contributor Author

updated title and description

@daryllabar
Copy link

daryllabar commented Nov 30, 2020

According to the documentation, content files are implicitly excluded, and can't be overwritten: https://docs.microsoft.com/en-us/nuget/reference/nuspec#dependencies-element

exclude A comma-delimited list of include/exclude tags (see below) indicating of the dependency to exclude in the final package. The default value is build,analyzers which can be over-written. But content/ ContentFiles are also implicitly excluded in the final package which can't be over-written. Tags specified with exclude take precedence over those specified with include. For example, include="runtime, compile" exclude="compile" is the same as include="runtime".

Not sure why though.

@jeffkl jeffkl added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed Pipeline:Icebox labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:ContentFiles PackageReference contentFiles folder Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug
Projects
None yet
Development

No branches or pull requests

6 participants