Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX3 Firmware] Code cleanup and potential improvements #205

Closed
jynik opened this issue Jan 14, 2014 · 2 comments
Closed

[FX3 Firmware] Code cleanup and potential improvements #205

jynik opened this issue Jan 14, 2014 · 2 comments
Assignees
Labels
Issue: Enhancement Missing functionality, or a new feature request

Comments

@jynik
Copy link
Contributor

jynik commented Jan 14, 2014

Just wanted to make a "FIXME" list of some things I saw while hunting for some bugs. While nothing in here is jumping out as immediate problems, I'd like to revisit these ASAP to improve robustness and potentially bring any undesired behavior to light.

  • Unchecked return values. A number of Cypress API calls are going unchecked.
  • Return status and propagate failures back to the host when possible rather than diving into the fatal error handler or locking up
  • Indicate some status upon encountering fatal errors. For example, blink the currently unused LED D10 in the existing fatal error handler, and perhaps map some unique blink rates/patterns for different failures.
  • Enable debug logging that can be retrieved from host. It appears that the CyU3PDebug* functions provide support for writing data out to a specified DMA socket. Perhaps we could add a compile-time opt-in for an IN EP for debug log data.
  • Change NuandGPIOReconfigure to internally track the cold/warm config rather than rely on callers. (Was there a specific case when we want caller's to force a full default reinitialization of pins?)
@ghost ghost assigned jynik Jan 14, 2014
@jynik jynik modified the milestone: 2014.09 Apr 27, 2014
@jynik
Copy link
Contributor Author

jynik commented Apr 27, 2014

A significant cleanup of the firmware will most likely be an objective after the 2014.09 release, as no immediate problems have been observed and overhauling this code presents an opportunity to introduce new defects.

@jynik
Copy link
Contributor Author

jynik commented Dec 29, 2015

Added return value checks and logging in d2ff39f.

@jynik jynik closed this as completed Dec 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Enhancement Missing functionality, or a new feature request
Projects
None yet
Development

No branches or pull requests

1 participant