Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: improve formatting #1578

Closed
KES777 opened this issue May 10, 2018 · 3 comments
Closed

DOC: improve formatting #1578

KES777 opened this issue May 10, 2018 · 3 comments

Comments

@KES777
Copy link

KES777 commented May 10, 2018

On the page

delete1

required keyword is not aligned properly and makes confusion a bit.

It would be more clear if you move this keyword after type and before properties

@darrelmiller
Copy link
Member

Thanks for spotting this. Would there be any chance you could create a PR to fix it against the 3.0.2-dev branch?

@MikeRalphson
Copy link
Member

It would be nice to have the required array positioned consistently with regard to the type and properties properties in all the examples. Personally I prefer it to follow properties, as then the required array isn't seen as referencing properties which haven't been introduced yet, but of course the notion of property ordering in JSON/JSON-schema is artificial.

@webron
Copy link
Member

webron commented Feb 11, 2020

Fixed by #2132.

@webron webron closed this as completed Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants