[16.0] product_pricelist_simulation "Unit sales price" is not updated when the date is changed

[FreezeS]

Hi guys,

I'm testing the product_pricelist_simulation module.
I have two pricelists, Master and LAB2 (derived from Master).

Pricelist LAB2 has 2 rules:

When I click on View Price per Pricelist, I get this:

This applies the 10% discount rule correctly.

However, if I change the date, nothing happens:

For the selected date is should have applied the 90% discount rule.

[legalsylvain]

Hi @FreezeS. Thanks for reporting.
Indeed, something is wrong in this function.

https://github.com/OCA/product-attribute/blob/16.0/product_pricelist_simulation/wizards/wizard_preview_pricelist.py#L46
price_date is not used and should be passed in _price_get.

It looks to be a regression introduced here 6f0d322#diff-23b9cef8dea11713559764c80590be7f0db6a68d06563c799d1693f1ada8b1dcR59 in #1348

Note : also changing the quantity should fail.

@HugoCordobaLeal, could you take a look ?
thanks !

[hugo-cordoba]

Hi @FreezeS @legalsylvain.

Thanks for reporting the error, I will take a look at it during the day when I have a free moment. I'll let you know.

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

[legalsylvain]

@hugo-cordoba : any news on that topic ?

Thanks !