Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [FIX]multi_image/multi_media and thumbnail orders #282

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

lmignon
Copy link
Contributor

@lmignon lmignon commented Oct 4, 2023

No description provided.

Ensures the variant_image_ids are sorted by sequence and name. Before this
change, the order was random and could change between runs.
@lmignon lmignon force-pushed the 16.0-fix-multi-image-sequence branch from 74cd9ac to b4dd7d8 Compare October 4, 2023 07:24
@lmignon lmignon marked this pull request as ready for review October 4, 2023 07:24
@lmignon lmignon changed the title wip [16.0] [FIX]multi_image/multi_media and thumbnail orders Oct 4, 2023
Ensures the variant_media_ids are sorted by sequence and name. Before this
change, the order was random and could change between runs.
To avoid 'Duplicate explicit target name' error in the rst files where 2 links reference the same url, we must use the  double underscores __ to make the reference anonymous
@lmignon lmignon force-pushed the 16.0-fix-multi-image-sequence branch from b059769 to 63679d2 Compare October 4, 2023 07:40
@lmignon
Copy link
Contributor Author

lmignon commented Oct 4, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-282-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 533a078 into OCA:16.0 Oct 4, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3ea8531. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-fix-multi-image-sequence branch October 4, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants