Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][web_widget_x2many_2d_matrix] cannot store fields values not included in the matrix #1084

Closed
simahawk opened this issue Oct 18, 2018 · 2 comments
Labels
bug help wanted stale PR/Issue without recent activity, it'll be soon closed automatically.
Milestone

Comments

@simahawk
Copy link
Contributor

Origin: OCA/product-variant#109 (comment)

Fields not included in the matrix are not considered on save.

@pedrobaeza @yajo is that all? Have you identified specific flaws or possible solutions?

@simahawk simahawk added this to the 11.0 milestone Oct 18, 2018
@pedrobaeza
Copy link
Member

Thanks for continuing this. You can check on the module sale_order_variant_mgmt in version 10, that the model shown on the matrix contains an extra field:

https://github.com/OCA/product-variant/blob/249bea07fcf1b202254c953d09c8b5d740f06ad6/sale_order_variant_mgmt/wizard/sale_manage_variant.py#L96-L105

which is product_id. That field was used for storing a temp value for finding the line.

Now on v11, extra values are not stored, giving an error with the same code (on v11 there's a workaround in this case).

@github-actions
Copy link

github-actions bot commented Jan 1, 2023

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 1, 2023
@github-actions github-actions bot closed this as completed Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

2 participants