-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we really want to retain type
= Object
and Version
with plain JSON?
#232
Comments
How do you check an object has the necessary keys in JSON Schema? I would want some sort of check that |
JSON schema makes no special use of
which simply says there must be a The JSON schema "looks" at the whole structure of the object and hence |
It doesn't buy us anything in terms of simplifying validation and I'm not sure it adds anything in terms of readability. Top level version number is, I think, a good idea though. |
I propose that at the top level we have a more OCFL specific key than
|
An embedded OCFL Object version would be helpful for cross-validation. |
A few related but not structured thoughts:
|
+1 for the human readability bit. It's one of the principles behind other bits of OCFL design. |
Discussion on 2018-11-21 editors' call: will remove |
On thinking about this more and looking at the current definition of |
I think I've always doubted the value of including these plain-text types (as opposed to semantic types in JSON-LD) but this was really brought whennhome listening to justification in the talk Rosy and I gave yesterday. I just didn't buy it. What value do they bring in a fixed JSON format? I could see having a type that included a version number at the top level (ie.
"type": "ocfl_object_1.0"
to match the NAMASTE file) which could then be a consistency/sanity check in validation. I don't see any benefit of having a type for each version object.The text was updated successfully, but these errors were encountered: