Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What limitations should there be on contentDirectory? #415

Closed
zimeon opened this issue Feb 6, 2020 · 3 comments · Fixed by #427
Closed

What limitations should there be on contentDirectory? #415

zimeon opened this issue Feb 6, 2020 · 3 comments · Fixed by #427
Assignees

Comments

@zimeon
Copy link
Contributor

zimeon commented Feb 6, 2020

As currently defined there are no restrictions on what contentDirectory might be. Perhaps:

Seems like an edge case so this could be left until after 1.0.

@pwinckles
Copy link

The spec does forbid / here.

The contentDirectory value MUST NOT contain the forward slash (/) path separator.

@zimeon
Copy link
Contributor Author

zimeon commented Feb 7, 2020

Thanks @pwinckles , that certainly answers my first bullet. I wonder whether there should be any other restrictions? For example, a contentDirectory of .. or . would not seem good

@pwinckles
Copy link

Yes, I agree. I am not allowing them in my client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants