Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logical paths MUST not have element . .. or //, but what about content paths? #462

Closed
zimeon opened this issue May 8, 2020 · 3 comments · Fixed by #472
Closed

Logical paths MUST not have element . .. or //, but what about content paths? #462

zimeon opened this issue May 8, 2020 · 3 comments · Fixed by #472
Assignees
Milestone

Comments

@zimeon
Copy link
Contributor

zimeon commented May 8, 2020

It seems we specify a number of restrictions on logical paths so that an object can be unpacked on a unix-like filesystem (https://ocfl.io/draft/spec/#version):

The logical path must be interpreted as a set of one or more path elements joined by a / path separator. Path elements must not be ., .., or empty (//). Additionally, a logical path MUST NOT begin or end with a forward slash (/).

but we don't actually say anything comparable about content paths (https://ocfl.io/draft/spec/#manifest). I think currently the following is not disallowed:

"manifest": {
    "7dcc35...c31": [ "v1/content/foo/down/../bar.xml" ],
    "cf83e1...a3e": [ "v1/content/////empty.txt" ],
    "ffccf6...62e": [ "v1/content/./././././image.tiff" ]
  }
@neilsjefferies
Copy link
Member

Likewise duplication and files can't also be folders.

@neilsjefferies
Copy link
Member

As per Community Call 13/5 - same restrictions as for logical paths (and a corresponding set of new error codes)

@zimeon zimeon self-assigned this May 19, 2020
@zimeon
Copy link
Contributor Author

zimeon commented May 19, 2020

2020-05-19 Editors agree that we should address this as described

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants