Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Clarify Namaste requirements #263

Merged
merged 2 commits into from
Dec 9, 2018
Merged

Fixed: Clarify Namaste requirements #263

merged 2 commits into from
Dec 9, 2018

Conversation

ahankinson
Copy link
Contributor

Fixes #261

Copy link
Contributor

@zimeon zimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this though not entirely sure it is worth introducing the T=dvalue language from the NAMASTE spec

@ahankinson
Copy link
Contributor Author

I wasn't sure how to otherwise talk about the "value of the filename that comes after the 'Number Equals' bit" in a succinct way.

be constructed with a leading zero-equals (<code>0=</code>) string, the string <code>ocfl_object_</code>,
followed by the OCFL specification version number. For example <code>0=ocfl_object_1.0</code> for version
1.0 of this specification.
The version declaration MUST be formatted according to the [[!NAMASTE]] specification. It MUST be an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an -> a

@@ -349,11 +349,12 @@ <h2>Object Structure</h2>
<section id="object-conformance-declaration">
<h2>Object Conformance Declaration</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the updated text, it would seem that the section title should now become: "Storage Root Conformance Declaration".

@@ -765,10 +766,10 @@ <h2>Root Structure</h2>
<h2>Root Conformance Declaration</h2>
<p>
The OCFL version declaration MUST be formatted according to the [[!NAMASTE]] specification. It MUST be an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an -> a

followed by the OCFL specification version number. For example <code>0=ocfl_object_1.0</code> for version
1.0 of this specification.
The version declaration MUST be formatted according to the [[!NAMASTE]] specification. It MUST be an
file in the base directory of the <a>OCFL Storage Root</a> giving the OCFL version in the filename.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the current section title, "Object Conformance Declaration", I would suggest not changing "base directory of the object" to "base directory of the OCFL Storage Root".
...unless we are no longer specifying the inclusion of a NAMASTE file in the object base.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is just a simple error, should be "OCFL Object" not "OCFL Storage Root"

rosy1280
rosy1280 previously approved these changes Nov 11, 2018
followed by the OCFL specification version number. For example <code>0=ocfl_object_1.0</code> for version
1.0 of this specification.
The version declaration MUST be formatted according to the [[!NAMASTE]] specification. It MUST be an
file in the base directory of the <a>OCFL Storage Root</a> giving the OCFL version in the filename.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rosy1280
Copy link
Contributor

once changes @awoods recommends making are changed i approve.

followed by the OCFL specification version number. For example <code>0=ocfl_object_1.0</code> for version
1.0 of this specification.
The version declaration MUST be formatted according to the [[!NAMASTE]] specification. It MUST be an
file in the base directory of the <a>OCFL Storage Root</a> giving the OCFL version in the filename.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is just a simple error, should be "OCFL Object" not "OCFL Storage Root"

@ahankinson
Copy link
Contributor Author

Refs #219 as well

@ahankinson
Copy link
Contributor Author

Errors have been fixed

Copy link
Contributor

@julianmorley julianmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@ahankinson
Copy link
Contributor Author

This can be merged now under the 72h rule.

@zimeon zimeon merged commit fb9a786 into master Dec 9, 2018
@zimeon zimeon deleted the fixed-261-namaste branch December 9, 2018 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants