-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Clarify Namaste requirements #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with this though not entirely sure it is worth introducing the T=dvalue
language from the NAMASTE spec
I wasn't sure how to otherwise talk about the "value of the filename that comes after the 'Number Equals' bit" in a succinct way. |
draft/spec/index.html
Outdated
be constructed with a leading zero-equals (<code>0=</code>) string, the string <code>ocfl_object_</code>, | ||
followed by the OCFL specification version number. For example <code>0=ocfl_object_1.0</code> for version | ||
1.0 of this specification. | ||
The version declaration MUST be formatted according to the [[!NAMASTE]] specification. It MUST be an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an
-> a
@@ -349,11 +349,12 @@ <h2>Object Structure</h2> | |||
<section id="object-conformance-declaration"> | |||
<h2>Object Conformance Declaration</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the updated text, it would seem that the section title should now become: "Storage Root Conformance Declaration".
draft/spec/index.html
Outdated
@@ -765,10 +766,10 @@ <h2>Root Structure</h2> | |||
<h2>Root Conformance Declaration</h2> | |||
<p> | |||
The OCFL version declaration MUST be formatted according to the [[!NAMASTE]] specification. It MUST be an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an
-> a
draft/spec/index.html
Outdated
followed by the OCFL specification version number. For example <code>0=ocfl_object_1.0</code> for version | ||
1.0 of this specification. | ||
The version declaration MUST be formatted according to the [[!NAMASTE]] specification. It MUST be an | ||
file in the base directory of the <a>OCFL Storage Root</a> giving the OCFL version in the filename. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the current section title, "Object Conformance Declaration", I would suggest not changing "base directory of the object" to "base directory of the OCFL Storage Root".
...unless we are no longer specifying the inclusion of a NAMASTE file in the object base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is just a simple error, should be "OCFL Object" not "OCFL Storage Root"
draft/spec/index.html
Outdated
followed by the OCFL specification version number. For example <code>0=ocfl_object_1.0</code> for version | ||
1.0 of this specification. | ||
The version declaration MUST be formatted according to the [[!NAMASTE]] specification. It MUST be an | ||
file in the base directory of the <a>OCFL Storage Root</a> giving the OCFL version in the filename. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
once changes @awoods recommends making are changed i approve. |
draft/spec/index.html
Outdated
followed by the OCFL specification version number. For example <code>0=ocfl_object_1.0</code> for version | ||
1.0 of this specification. | ||
The version declaration MUST be formatted according to the [[!NAMASTE]] specification. It MUST be an | ||
file in the base directory of the <a>OCFL Storage Root</a> giving the OCFL version in the filename. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is just a simple error, should be "OCFL Object" not "OCFL Storage Root"
Refs #219 as well |
Errors have been fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
This can be merged now under the 72h rule. |
Fixes #261