Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite introduction #357

Merged
merged 5 commits into from
Jun 3, 2019
Merged

Rewrite introduction #357

merged 5 commits into from
Jun 3, 2019

Conversation

rosy1280
Copy link
Contributor

fixes #186

Copy link
Contributor

@zimeon zimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General sense is good, I have noted a few typos and suggested some minor edits

draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
@rosy1280 rosy1280 requested a review from zimeon May 28, 2019 18:41
@rosy1280 rosy1280 self-assigned this May 29, 2019
ahankinson
ahankinson previously approved these changes May 29, 2019
Copy link
Member

@awoods awoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @rosy1280 . I few minor comments/suggestions.

draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
@zimeon zimeon merged commit 710ce0f into master Jun 3, 2019
@zimeon zimeon deleted the fixes-186 branch June 3, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review introduction to spec
5 participants