Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows fixes + OCAMLPATH compatibility #170

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nojb
Copy link
Contributor

@nojb nojb commented Apr 28, 2024

  • The first commit is needed for Windows compatibility.
  • The second commit makes ocp-index honour the OCAMLPATH environment variable (used by Dune, ocamlfind, etc) which is useful in non-OPAM contexts.

Let me know what you think! Thanks.

@CLAassistant
Copy link

CLAassistant commented Apr 28, 2024

CLA assistant check
All committers have signed the CLA.

@nojb
Copy link
Contributor Author

nojb commented Apr 28, 2024

Just FYI, with this PR it is now possible to use Down on Windows! (See dbuenzli/down#35)

@nojb
Copy link
Contributor Author

nojb commented May 20, 2024

Friendly ping.

Copy link
Contributor

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer but lgtm although i'm not sure where the expected format of OCAMLPATH is defined (wrt. quoting and separator) so i'll trust you on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants