Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unused CONST definition and MACROS #136

Closed
karataliu opened this issue Mar 30, 2015 · 4 comments
Closed

Clean up unused CONST definition and MACROS #136

karataliu opened this issue Mar 30, 2015 · 4 comments
Assignees
@lewischeng-ms

Comments

@karataliu
Copy link
Contributor

There're some legacy CONST definition and MACROS in the project.

WINDOWS_PHONE
ODATALIB_ASYNC
ASTORIA_SERVER
SILVERLIGHT
@lewischeng-ms
Copy link
Contributor

And also the macro WINRT is useful for next generation .NET platform but we should give it a more meaningful name.

@lewischeng-ms lewischeng-ms mentioned this issue May 7, 2015
Closed
@lewischeng-ms
Copy link
Contributor

ODATALIB_ASYNC should NOT be removed due to net35 and netcore50.
ASTORIA_SERVER should NOT be removed because it is used in OData.Service.
Also clean up ASTORIA_LIGHT

@lewischeng-ms
Copy link
Contributor

Renamed WINRT to DNXCORE50 to be compatible with the convention of .NET Core 5.

@lewischeng-ms
Copy link
Contributor

Checked in as d296d5d, 6636bc2 and 6c59557

@biaol-odata biaol-odata mentioned this issue Jul 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lewischeng-ms lewischeng-ms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lewischeng-ms @karataliu