Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public API changes don't fail build when applied to a subset of target frameworks #2433

Open
corranrogue9 opened this issue Jun 14, 2022 · 0 comments
Open

Public API changes don't fail build when applied to a subset of target frameworks #2433

corranrogue9 opened this issue Jun 14, 2022 · 0 comments
Assignees
@habbes
Labels
infrastructure build environment, engineering system and other things for developer productivity.

Comments

@corranrogue9
Copy link
Contributor

corranrogue9 commented Jun 14, 2022 •
edited
Loading

The corranrogue9/publicapi branch reproduces the issue. There is a new property that only applies to .NET standard 2.0. When building locally, the build fails. When building on the build server, the build succeeds.

These 4 need to be true:

  1. The build fails on the build server
  2. The build fails locally
  3. The public api tests fail locally (for both release and debug builds)
  4. The public api tests fail on the build server (for both release and debug builds)
@habbes habbes added the infrastructure build environment, engineering system and other things for developer productivity. label Jun 21, 2022
@habbes habbes self-assigned this Jun 21, 2022
@corranrogue9 corranrogue9 mentioned this issue Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@habbes habbes

Labels
infrastructure build environment, engineering system and other things for developer productivity.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@habbes @corranrogue9