refactor: use determinisitic provider id #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upstream ohdsi example can have non-determinisitic cases: use `patient_id` to make reproducible - order by state > city > zip > id (I think most logical form)
| @@ -1,5 +1,5 @@ | |||
| SELECT | |||
| row_number() OVER (ORDER BY (SELECT null)) AS provider_id | |||
| row_number() OVER (ORDER BY provider_state, provider_city, provider_zip, provider_id) AS provider_id | |||
There was a problem hiding this comment.
could we just use provider_id? it should be the PK from the source Synthea table right?
There was a problem hiding this comment.
yeah we could ~ I was going for something that would order somewhat logically (rather than UUIDv4s), but that's again not necessary
There was a problem hiding this comment.
ahh i see! just for readability/neatness. i'm fine to keep it this way then :)
|
I'll cleanup this branch when #83 is determined on this best approach :) |
lawrenceadams
changed the title
|
As a result of #83 this only affects provider now - I think |
katy-sadowski
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up code imported from upstream OHDSI/SyntheaETL SQL code, where models can produce non-deterministic output for
locationandprovidertables.For both tables, output is now ordered by:
Perhaps this is too complicated, open to other ideas! I think this is somewhat more logical than doing:
city > state > zip > _id, but may not be correct to US-centric norms