Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with webpack(?) - "hot update was not successful" #2608

Closed
DavidBerger98 opened this issue Nov 9, 2021 · 2 comments
Closed

Issue with webpack(?) - "hot update was not successful" #2608

DavidBerger98 opened this issue Nov 9, 2021 · 2 comments

Comments

@DavidBerger98
Copy link

I cloned the latest version of the master branch, ran yarn install, then yarn run dev and encountered an error page saying "hot update was not successful". In the console there are a couple errors, one of them saying Uncaught Error: Cannot find module 'dom-helpers/addClass'.

I am using Ubuntu 20.04.3, node 14.18.1, npm 6.14.15, yarn 1.22.17.

It seems to be a problem with webpack.
I got the problem fixed by doing the following in .webpack/webpack.base.js:
add to module.rules

rules: [...,
  {
    test: /\.js$/,
    exclude: /node_modules(?!(\/|\\)pdfjs-dist)/,
    loader: 'babel-loader',
    options: {
      'presets': ['@babel/preset-env'],
      'plugins': ['@babel/plugin-proposal-optional-chaining']
    }
  }
]

replace resolve.modules with:

modules: ["node_modules"]

See here and here for more.

I am not versed enough in webpack stuff to understand what exactly is going on, but I thought I'd share in case someone has the same error. Maybe someone can check if that fix makes sense.

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale 🥖 label Jun 12, 2022
@sedghi sedghi removed the Stale 🥖 label Jan 11, 2023
@sedghi
Copy link
Member

sedghi commented Oct 13, 2023

Please review the latest code in the master branch. This issue might have been resolved. If it persists, kindly reopen the issue with updated details.

Try viewer-dev.ohif.org instead of viewer.ohif.org
Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master branch
Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing

@sedghi sedghi closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants