-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data source UI config): Popup the configuration dialogue whenever a data source is not fully configured #3620
feat(data source UI config): Popup the configuration dialogue whenever a data source is not fully configured #3620
Conversation
…r a data source is not fully configured.
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3620 +/- ##
=======================================
Coverage 42.58% 42.58%
=======================================
Files 80 80
Lines 1463 1463
Branches 340 340
=======================================
Hits 623 623
Misses 675 675
Partials 165 165 Continue to review full report in Codecov by Sentry.
|
extensions/default/src/DataSourceConfigurationAPI/GoogleCloudDataSourceConfigurationAPI.ts
Show resolved
Hide resolved
extensions/default/src/Components/DataSourceConfigurationModalComponent.tsx
Show resolved
Hide resolved
extensions/default/src/Components/DataSourceConfigurationComponent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor doc requests, thanks
Updated the cornerstone version.
…configuration-api-and-gui
…configuration-api-and-gui
…r a data source is not fully configured (OHIF#3620)
Context
If a data source is not fully configured (e.g. the various wado, qido, etc roots are not set), then OHIF should popup the data source configuration modal to configure the data source.
Changes & Results
Instead of navigating to the server not found page, give any data source with a configuration API the chance to configure itself via the UI.
Testing
config/google.js
configuration file.Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment