Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data source UI config): Popup the configuration dialogue whenever a data source is not fully configured #3620

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

jbocce
Copy link
Contributor

@jbocce jbocce commented Aug 28, 2023

Context

If a data source is not fully configured (e.g. the various wado, qido, etc roots are not set), then OHIF should popup the data source configuration modal to configure the data source.

Changes & Results

Instead of navigating to the server not found page, give any data source with a configuration API the chance to configure itself via the UI.

Testing

  1. Check out the branch for this PR.
  2. Remove the various configuration paths for the 'dicomweb' data source from the config/google.js configuration file.
  3. Set the configuration file to be google.js.
  4. Start OHIF and navigate to the client.
  5. The 'Configure Data Source' modal should be displayed and should allow the Google Cloud Healthcare data source to be configured.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 16.14.0
  • Browser: Chrome 115.0.5790.171

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit a2554f4
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64ee2e9bb1d8ae0008163764
😎 Deploy Preview https://deploy-preview-3620--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit a2554f4
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64ee2e9baeacb30008e9ce74
😎 Deploy Preview https://deploy-preview-3620--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jbocce jbocce requested a review from sedghi August 28, 2023 15:07
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #3620 (a2554f4) into master (35fc30c) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3620   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files          80       80           
  Lines        1463     1463           
  Branches      340      340           
=======================================
  Hits          623      623           
  Misses        675      675           
  Partials      165      165           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5856ae2...a2554f4. Read the comment docs.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor doc requests, thanks

Joe Boccanfuso added 2 commits August 29, 2023 12:34
Updated the cornerstone version.
@jbocce jbocce requested a review from sedghi August 29, 2023 16:49
@jbocce jbocce requested a review from sedghi August 30, 2023 13:25
@sedghi sedghi merged commit adedc8c into OHIF:master Aug 30, 2023
8 of 9 checks passed
Sofien-Sellami pushed a commit to Sofien-Sellami/Viewers that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants