Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microscopy features not working #3801

Closed
tzuccher opened this issue Nov 21, 2023 · 2 comments
Closed

Microscopy features not working #3801

tzuccher opened this issue Nov 21, 2023 · 2 comments
Assignees
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)

Comments

@tzuccher
Copy link

Describe the Bug

Multiple microscopy features are currently not working:

  1. cannot drag and drop SM images from the left study panel into the viewport
  2. creating length measurements sometimes works and other times i cannot get the measure to appear on the image
  3. the Point tool creates the measurement (recorded in the measurement panel) but you cannot see them on the image
  4. right click on a measurement on the image does not bring up the options to Add Label or Delete Measurement (there is no way to delete)

Steps to Reproduce

This was found in both of the following environments:
https://viewer.ohif.org/ - version 3.7.0
https://viewer-dev.ohif.org/ - version 3.8.0-beta.21

  1. From the study list filter on modality: SM - select an SM study and click on the Microscopy button
  2. from the viewer screen, expand the study list panel and try to drag and drop the second series appearing = nothing happens. That SM series will not appear in the viewport and replace the SM image that was displayed on entry to the screen
  3. Click on the length tool and click on the image to create a line with the mouse = this is random to create the line - sometimes it creates it and sometimes it takes a few attempts. Expand the measurements panel to see the measure when it is successful
  4. Click on the Point tool and create points on the image. The points will appear as entries in the measurements panel but the points themselves will disappear from the image. The only way to see that a point is there is to click on the entry in the measurements panel and the active measure becomes yellow (but to be consistent with other modalities and measurements, i think active measurements should be green?)
  5. Right-click on any existing measurements on the SM image and you should get a menu that includes: add label + delete measurement: this is consistent with other modalities image features

The current behavior

missing features consistent with other modality image features

The expected behavior

  1. drag and drop series images to the active viewport
  2. measurement features to add measurement, label & delete

OS

MacBook Pro - Sonoma 14.1.1

Node version

unknown

Browser

Chrome v119

@tzuccher tzuccher added the Awaiting Reproduction Can we reproduce the reported bug? label Nov 21, 2023
@sedghi sedghi added Bug Verified Bug reported, reproducible, and verified. Awaiting Reproduction Can we reproduce the reported bug? and removed Awaiting Reproduction Can we reproduce the reported bug? labels Nov 22, 2023
@james-hanks
Copy link

@sedghi to provide estimate

@sedghi sedghi removed the Awaiting Reproduction Can we reproduce the reported bug? label Nov 27, 2023
@sedghi sedghi added fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org) and removed Bug Verified Bug reported, reproducible, and verified. labels Jan 9, 2024
@sedghi
Copy link
Member

sedghi commented May 1, 2024

We just release the OHIF 3.8, you can find more details here https://ohif.org/release-notes/3p8/
If you still encounter this issue in 3.8, please re-open this.

@sedghi sedghi closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)
Projects
None yet
Development

No branches or pull requests

3 participants