Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

fix(StudyMetadata): Gets the modality information from first series item #55

Merged
merged 2 commits into from
Jul 21, 2019
Merged

fix(StudyMetadata): Gets the modality information from first series item #55

merged 2 commits into from
Jul 21, 2019

Conversation

joao-f-medeiros
Copy link
Contributor

If the Display Set doesn't have the series image information, we were always adding SR for the modality, this change allows us to get this information from the first series instance.

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #55 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #55      +/-   ##
=========================================
- Coverage   10.11%   10.1%   -0.01%     
=========================================
  Files         154     154              
  Lines        4420    4424       +4     
  Branches      907     908       +1     
=========================================
  Hits          447     447              
- Misses       3129    3132       +3     
- Partials      844     845       +1
Impacted Files Coverage Δ
src/classes/metadata/StudyMetadata.js 2.5% <0%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33fba8e...d730a44. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #55 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #55      +/-   ##
=========================================
- Coverage   10.11%   10.1%   -0.01%     
=========================================
  Files         154     154              
  Lines        4420    4424       +4     
  Branches      907     908       +1     
=========================================
  Hits          447     447              
- Misses       3129    3132       +3     
- Partials      844     845       +1
Impacted Files Coverage Δ
src/classes/metadata/StudyMetadata.js 2.5% <0%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33fba8e...debae2a. Read the comment docs.

dicomWebClient,
headers
);
if (displaySet) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this if (displaySet && !displaySet.modality), so we don't overwrite what the plugin returned?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will change it here

@swederik swederik merged commit d51ce4f into OHIF:master Jul 21, 2019
@ohif-bot
Copy link
Member

🎉 This PR is included in version 0.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants