This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
fix(ToolbarSection): Set label as non required to remove unnecessary w… #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arning in case a button is a group which uses text instead
|
@igoroctaviano, can't it use label in both instances? |
@dannyrb Done, thanks! I just updated the other component that was using text prop instead of label. I have also updated other button components for naming consistency. |
|
@igoroctaviano, you can merge if you're happy with this. Might be worth notifying consumers like @evren217 and others as they may depend on these components. |
|
🎉 This PR is included in version 0.17.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary warning when a button is a group. When its group the ExpandableMenu expects text instead of label.