rust: compatibility with cbindgen 0.27 #11622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7206 Cbindgen 0.27 now handles extern blocks as extern "C" blocks. The way to differentiate them is to use a special comment before the block.
This was referenced Aug 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11622 +/- ##
==========================================
+ Coverage 82.52% 82.61% +0.09%
==========================================
Files 919 919
Lines 248997 248997
==========================================
+ Hits 205480 205717 +237
+ Misses 43517 43280 -237
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I think CIFuzz tries first to build master before building this PR... |
4 tasks
|
See also google/oss-fuzz#12336 |
jasonish
reviewed
Aug 12, 2024
Comment on lines
+52
to
+54
| // Allow /// cbindgen:ignore comments on extern blocks | ||
| // cf https://github.com/mozilla/cbindgen/issues/709 | ||
| #![allow(unused_doc_comments)] |
There was a problem hiding this comment.
Annoying that this is required.
There was a problem hiding this comment.
Maybe we can have these individually and not globally..?
|
Information: QA ran without warnings. Pipeline 22077 |
jasonish
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7206
Describe changes:
Should make CI green again