Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list-keywords: initialize sigtable before setup #12137

Closed
wants to merge 1 commit into from

Conversation

jasonish
Copy link
Member

This broke with commit 2ac16ee which
separated SigTableSetup into SigTableSetup and SigTableInit.

This broke with commit 2ac16ee which
separated SigTableSetup into SigTableSetup and SigTableInit.
@victorjulien
Copy link
Member

duplicate of #12124?

@jasonish
Copy link
Member Author

duplicate of #12124?

Ah, so it is.

@jasonish jasonish closed this Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.10%. Comparing base (5d766df) to head (423a1eb).

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12137       +/-   ##
===========================================
+ Coverage   62.68%   83.10%   +20.42%     
===========================================
  Files         840      909       +69     
  Lines      153669   257884   +104215     
===========================================
+ Hits        96323   214321   +117998     
+ Misses      57346    43563    -13783     
Flag Coverage Δ
fuzzcorpus 60.93% <0.00%> (?)
livemode 19.43% <0.00%> (?)
pcap 44.40% <0.00%> (?)
suricata-verify 62.67% <0.00%> (-0.01%) ⬇️
unittests 59.27% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants