Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: minor fixup + mention nss removal - v1 #6374

Closed
wants to merge 2 commits into from
Closed

doc: minor fixup + mention nss removal - v1 #6374

wants to merge 2 commits into from

Conversation

jasonish
Copy link
Member

No description provided.

@jasonish jasonish requested a review from norg as a code owner September 13, 2021 20:33
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #6374 (cb2a440) into master (ca760e3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6374   +/-   ##
=======================================
  Coverage   76.96%   76.97%           
=======================================
  Files         612      612           
  Lines      186410   186409    -1     
=======================================
+ Hits       143477   143489   +12     
+ Misses      42933    42920   -13
Flag Coverage Δ
fuzzcorpus 52.67% <ø> (-0.08%) ⬇️
suricata-verify 51.57% <ø> (+0.05%) ⬆️
unittests 63.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien mentioned this pull request Sep 17, 2021
Merged
@victorjulien
Copy link
Member

Merged as part of #6383, thanks!

@jasonish jasonish deleted the doc-upgrade-fixup/v1 branch September 17, 2021 14:40
glongo added a commit to glongo/suricata that referenced this pull request Apr 14, 2024
@glongo
detect/sip: add stub file for headers keywords
383645c 
A stub file has been added to implement the sticky buffers for SIP headers.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 14, 2024
@glongo
rust/sip: store response headers
a1ee06c 
To match on response SIP headers, those headers must be stored.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 14, 2024
@glongo
rust/sip: match on headers map
e3c4c88 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 14, 2024
@glongo
detect/sip: add sip.from sticky buffer
eb8883a 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 14, 2024
@glongo
detect/sip: add sip.to sticky buffer
9288988 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 14, 2024
@glongo
detect/sip: add sip.via sticky buffer
7972845 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 14, 2024
@glongo
detect/sip: add sip.user_agent sticky buffer
4172535 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 14, 2024
@glongo
detect/sip: add sip.content_type sticky buffer
249aaaa 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 14, 2024
@glongo
detect/sip: add sip.content_length sticky buffer
d2d5373 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 14, 2024
@glongo
detect/sip: register headers sticky buffers
300f5b9 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 18, 2024
@glongo
detect/sip: add stub file for headers keywords
e23913a 
A stub file has been added to implement the sticky buffers for SIP headers.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 18, 2024
@glongo
rust/sip: store response headers
f8fc238 
To match on response SIP headers, those headers must be stored.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 18, 2024
@glongo
rust/sip: match on headers map
f9b7215 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 18, 2024
@glongo
detect/sip: add sip.from sticky buffer
e061f30 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 18, 2024
@glongo
detect/sip: add sip.to sticky buffer
f6ff049 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 18, 2024
@glongo
detect/sip: add sip.via sticky buffer
d087d4d 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 18, 2024
@glongo
detect/sip: add sip.user_agent sticky buffer
3dca93b 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 18, 2024
@glongo
detect/sip: add sip.content_type sticky buffer
f5703d8 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 18, 2024
@glongo
detect/sip: add sip.content_length sticky buffer
a9808b8 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 18, 2024
@glongo
detect/sip: register headers sticky buffers
52f3f7f 
Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 30, 2024
@glongo
detect/sip: add stub file for headers keywords
c3f3f54 
A stub file has been added to implement the sticky buffers for SIP headers.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Apr 30, 2024
@glongo
rust/sip: store response headers
0c89a9d 
To match on response SIP headers, those headers must be stored.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Aug 10, 2024
@glongo
sip: add sip.to sticky buffer
2b3c2d3 
This adds a sticky (multi) buffer to match the 'To' header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Aug 10, 2024
@glongo
sip: add sip.via sticky buffer
8af4846 
This adds a sticky (multi) buffer to match the "Via" header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Aug 10, 2024
@glongo
sip: add sip.user_agent sticky buffer
1b6c2cf 
This adds a sticky (multi) buffer to match the "User-Agent" header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Aug 10, 2024
@glongo
sip: add sip.content_type sticky buffer
73ff99a 
This adds a sticky (multi) buffer to match the "Content-Type" header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Aug 10, 2024
@glongo
sip: add sip.content_length sticky buffer
f9276f2 
This adds a sticky (multi) buffer to match the "Content-Length" header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Aug 28, 2024
@glongo
rust/sip: store multiple header values
2b569f8 
According to RFC 3261, a single header can be repeated one or more times,
and its name can also be specified using the 'compact form.'

This patch updates the hashmap used for storing headers to accommodate multiple
values instead of just one.

Additionally, if a header name is defined in the compact form, it is expanded
into its long form (i.e., the standard name).

This conversion simplifies the logic for matching a given header
and ensures 1:1 parity with keywords.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Aug 28, 2024
@glongo
rust/sip: store response headers
987f13a 
To match on response SIP headers, those headers must be stored.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Aug 28, 2024
@glongo
sip: add sip.from sticky buffer
08cf556 
This adds a sticky (multi) buffer to match the "From" header field
in both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Aug 28, 2024
@glongo
sip: add sip.to sticky buffer
3c5bea5 
This adds a sticky (multi) buffer to match the 'To' header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Aug 28, 2024
@glongo
sip: add sip.via sticky buffer
6e41880 
This adds a sticky (multi) buffer to match the "Via" header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Aug 28, 2024
@glongo
sip: add sip.user_agent sticky buffer
940a189 
This adds a sticky (multi) buffer to match the "User-Agent" header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Aug 28, 2024
@glongo
sip: add sip.content_type sticky buffer
5bc5b86 
This adds a sticky (multi) buffer to match the "Content-Type" header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Aug 28, 2024
@glongo
sip: add sip.content_length sticky buffer
607ba1e 
This adds a sticky (multi) buffer to match the "Content-Length" header field in
both requests and responses.

Ticket OISF#6374
@catenacyber catenacyber mentioned this pull request Sep 9, 2024
Closed
4 tasks
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Sep 22, 2024
@glongo @victorjulien
rust/sip: store multiple header values
cfb793c 
According to RFC 3261, a single header can be repeated one or more times,
and its name can also be specified using the 'compact form.'

This patch updates the hashmap used for storing headers to accommodate multiple
values instead of just one.

Additionally, if a header name is defined in the compact form, it is expanded
into its long form (i.e., the standard name).

This conversion simplifies the logic for matching a given header
and ensures 1:1 parity with keywords.

Ticket OISF#6374
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Sep 22, 2024
@glongo @victorjulien
rust/sip: store response headers
fbc3cd1 
To match on response SIP headers, those headers must be stored.

Ticket OISF#6374
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Sep 22, 2024
@glongo @victorjulien
sip: add sip.from sticky buffer
e3fefcf 
This adds a sticky (multi) buffer to match the "From" header field
in both requests and responses.

Ticket OISF#6374
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Sep 22, 2024
@glongo @victorjulien
sip: add sip.to sticky buffer
c205e87 
This adds a sticky (multi) buffer to match the 'To' header field in
both requests and responses.

Ticket OISF#6374
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Sep 22, 2024
@glongo @victorjulien
sip: add sip.via sticky buffer
6ddc7d6 
This adds a sticky (multi) buffer to match the "Via" header field in
both requests and responses.

Ticket OISF#6374
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Sep 22, 2024
@glongo @victorjulien
sip: add sip.user_agent sticky buffer
5e8e61b 
This adds a sticky (multi) buffer to match the "User-Agent" header field in
both requests and responses.

Ticket OISF#6374
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Sep 22, 2024
@glongo @victorjulien
sip: add sip.content_type sticky buffer
6f727ab 
This adds a sticky (multi) buffer to match the "Content-Type" header field in
both requests and responses.

Ticket OISF#6374
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Sep 22, 2024
@glongo @victorjulien
sip: add sip.content_length sticky buffer
d43154a 
This adds a sticky (multi) buffer to match the "Content-Length" header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Sep 22, 2024
@glongo
rust/sip: store multiple header values
02b04b7 
According to RFC 3261, a single header can be repeated one or more times,
and its name can also be specified using the 'compact form.'

This patch updates the hashmap used for storing headers to accommodate multiple
values instead of just one.

Additionally, if a header name is defined in the compact form, it is expanded
into its long form (i.e., the standard name).

This conversion simplifies the logic for matching a given header
and ensures 1:1 parity with keywords.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Sep 22, 2024
@glongo
rust/sip: store response headers
5ab0a6d 
To match on response SIP headers, those headers must be stored.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Sep 22, 2024
@glongo
sip: add sip.from sticky buffer
da5b250 
This adds a sticky (multi) buffer to match the "From" header field
in both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Sep 22, 2024
@glongo
sip: add sip.to sticky buffer
d18dfcd 
This adds a sticky (multi) buffer to match the 'To' header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Sep 22, 2024
@glongo
sip: add sip.via sticky buffer
dfd7f17 
This adds a sticky (multi) buffer to match the "Via" header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Sep 22, 2024
@glongo
sip: add sip.user_agent sticky buffer
8687d4c 
This adds a sticky (multi) buffer to match the "User-Agent" header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Sep 22, 2024
@glongo
sip: add sip.content_type sticky buffer
9ce89f3 
This adds a sticky (multi) buffer to match the "Content-Type" header field in
both requests and responses.

Ticket OISF#6374
glongo added a commit to glongo/suricata that referenced this pull request Sep 22, 2024
@glongo
sip: add sip.content_length sticky buffer
467cc2c 
This adds a sticky (multi) buffer to match the "Content-Length" header field in
both requests and responses.

Ticket OISF#6374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norg norg Awaiting requested review from norg

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonish @victorjulien