-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
versions_update #179
Merged
Merged
versions_update #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poetry.lock was updated by upgrading the version of various dependencies such as `anyio`, `astroid`, `asttokens`, `bumpversion` and many more. Additionally, new 'files' objects were included for each package, containing details about each respective package files.
The code changes all instances of `pd.to_datetime` with a custom function `convert_to_datetime`. This function is able to correctly handle different date formats, particularly when the date information only represents a year. Additional changes include reducing explicit regex flag usage in `str.replace` and reordering some assignments for cleaner code structure.
The test data file 'weo2023_2.csv' has been added. The expected results of several test assertions in 'test_dataframe_tools/test_add.py' and 'test_cleaning_tools/test_clean.py' have been updated to match the current implementation. This will help in maintaining the robustness of the testing process for the data cleaning and dataframe tools.
Various files across the project had unnecessary blank lines which have been removed in this commit. These changes make the code more concise and easy to read. It's a part of making the code adhere to best coding practices for readability.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 73.06% 73.07%
=======================================
Files 25 25
Lines 1526 1545 +19
=======================================
+ Hits 1115 1129 +14
- Misses 411 416 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request contains various updates such as the addition of a new test data file, enhancements to the code for enhanced readability and functionality, and updates to the dependencies in poetry.lock.
Commit 1 (fa69631)
Add new test data file and update test assertions
Jorge Rivera jorge.rivera@one.org
The test data file 'weo2023_2.csv' has been added. The expected results of several test assertions in 'test_dataframe_tools/test_add.py' and 'test_cleaning_tools/test_clean.py' have been updated to match the current implementation. This helps in maintaining the robustness of the testing process for the data cleaning and dataframe tools.
Commit 2 (a70bc94)
Replace native
pd.to_datetime
usage withconvert_to_datetime
Jorge Rivera jorge.rivera@one.org
The code changes all instances of
pd.to_datetime
with a custom functionconvert_to_datetime
. This function is able to correctly handle different date formats, particularly when the date information only represents a year. Additional changes include reducing explicit regex flag usage instr.replace
and reordering some assignments for cleaner code structure.Commit 3 (3234ae4)
Update poetry.lock dependencies version and add files
Jorge Rivera jorge.rivera@one.org
Poetry.lock was updated by upgrading the version of various dependencies such as
anyio
,astroid
,asttokens
,bumpversion
and many more. Additionally, new 'files' objects were included for each package, containing details about each respective package files.