Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versions_update #179

Merged
merged 8 commits into from
Dec 11, 2023
Merged

versions_update #179

merged 8 commits into from
Dec 11, 2023

Conversation

jm-rivera
Copy link
Collaborator

Summary

This pull request contains various updates such as the addition of a new test data file, enhancements to the code for enhanced readability and functionality, and updates to the dependencies in poetry.lock.

Commit 1 (fa69631)

Add new test data file and update test assertions

Jorge Rivera jorge.rivera@one.org
The test data file 'weo2023_2.csv' has been added. The expected results of several test assertions in 'test_dataframe_tools/test_add.py' and 'test_cleaning_tools/test_clean.py' have been updated to match the current implementation. This helps in maintaining the robustness of the testing process for the data cleaning and dataframe tools.

Commit 2 (a70bc94)

Replace native pd.to_datetime usage with convert_to_datetime

Jorge Rivera jorge.rivera@one.org
The code changes all instances of pd.to_datetime with a custom function convert_to_datetime. This function is able to correctly handle different date formats, particularly when the date information only represents a year. Additional changes include reducing explicit regex flag usage in str.replace and reordering some assignments for cleaner code structure.

Commit 3 (3234ae4)

Update poetry.lock dependencies version and add files

Jorge Rivera jorge.rivera@one.org
Poetry.lock was updated by upgrading the version of various dependencies such as anyio, astroid, asttokens, bumpversion and many more. Additionally, new 'files' objects were included for each package, containing details about each respective package files.

Poetry.lock was updated by upgrading the version of various dependencies such as `anyio`, `astroid`, `asttokens`, `bumpversion` and many more. Additionally, new 'files' objects were included for each package, containing details about each respective package files.
The code changes all instances of `pd.to_datetime` with a custom function `convert_to_datetime`. This function is able to correctly handle different date formats, particularly when the date information only represents a year. Additional changes include reducing explicit regex flag usage in `str.replace` and reordering some assignments for cleaner code structure.
The test data file 'weo2023_2.csv' has been added. The expected results of several test assertions in 'test_dataframe_tools/test_add.py' and 'test_cleaning_tools/test_clean.py' have been updated to match the current implementation. This will help in maintaining the robustness of the testing process for the data cleaning and dataframe tools.
@jm-rivera jm-rivera self-assigned this Dec 11, 2023
@jm-rivera jm-rivera added bug Something isn't working enhancement New feature or request labels Dec 11, 2023
Various files across the project had unnecessary blank lines which have been removed in this commit. These changes make the code more concise and easy to read. It's a part of making the code adhere to best coding practices for readability.
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (09a38d4) 73.06% compared to head (70ca933) 73.07%.

Files Patch % Lines
bblocks/cleaning_tools/clean.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   73.06%   73.07%           
=======================================
  Files          25       25           
  Lines        1526     1545   +19     
=======================================
+ Hits         1115     1129   +14     
- Misses        411      416    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jm-rivera jm-rivera merged commit 40e2458 into main Dec 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant