Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

182 bug weo importer #183

Merged
merged 7 commits into from
Apr 18, 2024
Merged

182 bug weo importer #183

merged 7 commits into from
Apr 18, 2024

Conversation

lpicci96
Copy link
Collaborator

This adds a method to WEO which returns the data in the old weo-reader format.

Note: All WEO data is returned by this function, not just the loaded indicators
Some columns that were present in the old format, are not available in sdmx data files, but these are not used in any analysis so should not cause errors.

@jm-rivera Should I leave it to you to patch this to the WorldEconomicOutlook class?

@lpicci96 lpicci96 requested a review from jm-rivera April 17, 2024 14:14
@lpicci96 lpicci96 linked an issue Apr 17, 2024 that may be closed by this pull request
@jm-rivera
Copy link
Collaborator

Attempting to patch but right now it returns this error:

KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['indicator_description']

Is that something you can get in the response? Otherwise i can remove it from the implementation. I don't think we use it in production.

@jm-rivera
Copy link
Collaborator

Attempting to patch but right now it returns this error:

KeyError: "The following id_vars or value_vars are not present in the DataFrame: ['indicator_description']

Is that something you can get in the response? Otherwise i can remove it from the implementation. I don't think we use it in production.

I think in the mapping it expects it to be Subject Notes. I think you've given it a different name here.

col_mapper = {
            "concept_code": "WEO Subject Code",
            "ref_area_code": "WEO Country Code",
            "lastactualdate": "Estimates Start After",
            "notes": "Country/Series-specific Notes",
            "unit": "Units",
            "concept": "Subject Descriptor",
            "ref_area": "Country",
            "scale": "Scale",
        }

@jm-rivera jm-rivera merged commit 93da6b0 into main Apr 18, 2024
1 of 2 checks passed
@jm-rivera jm-rivera deleted the 182-bug-weo-importer branch April 18, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: WEO importer
2 participants