Prepare/1.13.0 #1043
Merged
Prepare/1.13.0 #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set node for GR-Procedure-PlaceOfPerformance to be ND-ProcedurePlacePerformanceAdditionalInformation, which is the correct one, although its identifier is confusing.
Change the constraints for "Deadline Receipt Requests" from forbidden to mandatory for notice subtype 15. Update corresponding schematron rules, the affected notice example and validation report. Also update translations for the corresponding rules messages.
The fields for "Deadline Receipt Requests" are now mandatory for this notice subtype, so add them in the notice type definition.
Update the condition for the forbidden constraint on BT-40-Lot, to indicate it can only be present if BT-809-Lot is present. Update corresponding schematron rules, and translations for those rules.
Update all translations affected.
Stage 1 rules should only check the presence of XML elements that are used as part of the context of a stage 2 rule (mandatory or forbidden without condition). This was not done correctly, causing some extra stage 1 rules to be generated. Most of those extra rules were just redundant, except for one rule on cac:SpecificTendererRequirement for subtype E3, due to a specific situation (BT-71-Lot is optional for E3). This rule caused an incorrect failure when BT-761-Lot was filled in. Remove all incorrect/redundant rules. Also update affected validation reports, to remove the corresponding fired rules.
It's a technical id, so it should not be shown.
Also update corresponding schematron rules, and add new translations.
Group description of all changes related to the amendment in a specific section at the top, and remove specific item in the various other sections.
Also update corresponding schematron rules.
YvesJo
reviewed
Nov 7, 2024
| * E3 voluntary Competition | ||
| * E4 voluntary Result | ||
| * E5 Contract Completion, new _completion_ form type and _compl_ notice-type, including new Review section, also added to all Result notices (subtypes 29-37, E4, E5) | ||
| * E6 Contract Modification for defence directive 2009/81/EC |
There was a problem hiding this comment.
defence directive 2009/81/EC and "below threshold" procurements
Update corresponding schematron rules, and translations for rule messages.
Also add translations in the "translations" folder.
Also update corresponding schematron rules, and translations for rule messages.
Remove various mandatory constraints on fields in group of lots, for subtypes E3, E4 and E5. Also update corresponding schematron rules.
Also update affected schematron rules and validation reports.
Add "neg-w-call" in the codelists for notice subtypes 10 to 14. Update the corresponding schematron rules, and add the translations entries. Fixes issue #1065.
Update forbidden and mandatory constraints for BT-1311(d)-Lot and BT-1311(t)-Lot for notice subtype 15. Update corresponding schematron rules and rule messages.
Make regex pattern less strict to detect any occurrence of "test", regardless of case, and even as part of a word.
Remove constraints that forbid a Buyer or a Tenderer to be a service provider. Remove corresponding schematron rules.
The fields for BT-1311 were previously forbidden for subtype 15, they are now optional, so add a line in the view template so that they are displayed.
bertrand-lorentz
previously approved these changes
Nov 28, 2024
ferrakaop
approved these changes
Nov 28, 2024
bertrand-lorentz
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update version numbers
first draft of changelog