core: fix print_kernel_stack() #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooops! Looks like it is something I omitted to do when we decided to drop the special meaning of zeroes for exidx/exidx_sz during the review of 31a2964 ("core: dump call stack of user TAs on abort") :( I'm not sure this special meaning for zeroes ever reached mainline, it was only during the review that this change occurred, therefore the "previously" part of the commit message may not be very useful. And please add a
I think we should take this in 2.5.0 if no one objects. |
|
Very efficient. Yes please, if no one objects, merge in 2.5.0. |
jenswi-linaro
force-pushed
the
print_kernel_stack
branch
from
f1be7e7
to
b00ac01
Compare
Previously was print_kernel_stack() supplying zeroes instead of real values for start and size of exidx tables needed for unwind. With this patch are correct values for exidx and exidx_sz supplied. Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (b2260) Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Fixes: 31a2964 ("core: dump call stack of user TAs on abort") Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU) Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
jenswi-linaro
force-pushed
the
print_kernel_stack
branch
from
b00ac01
to
80bb126
Compare
|
Update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously was print_kernel_stack() supplying zeroes instead of real
values for start and size of exidx tables needed for unwind. With this
patch are correct values for exidx and exidx_sz supplied.
Tested-by: Jens Wiklander jens.wiklander@linaro.org (QEMU)
Signed-off-by: Jens Wiklander jens.wiklander@linaro.org