regression 4002: add CMAC test case with a 16 bytes increment #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you're targeting a bug that is supposed to be fixed please mention that in the commit message. A link to OP-TEE/optee_os#4583 in the commit message should be useful. |
jforissier
approved these changes
Apr 29, 2021
clementfaure
force-pushed
the
upstream/test_cmac_caam_input_size
branch
from
59b3b46 to
ffa6694
Compare
|
@jenswi-linaro @jforissier Commit reworded! |
|
|
clementfaure
force-pushed
the
upstream/test_cmac_caam_input_size
branch
from
ffa6694 to
3c82a08
Compare
|
"does not properly handle"? That was the problem that was fixed, right? So you can't say that. Instead "This is a test case for a bug in the CAAM CMAC driver which would not handle... [1]" and |
|
Indeed, that's not well written 🤦 yes, this is the problem fixed |
Add a CMAC subtest where do_update operations are done with a data input size of 16 bytes. This is a test case for a bug in the CAAM CMAC driver which would not handle properly consecutive do_update operations with input data size of 16 bytes. Link: OP-TEE/optee_os#4583 Signed-off-by: Clement Faure <clement.faure@nxp.com> Reviewed-by: Jerome Forissier <jerome@forissier.org> Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
clementfaure
force-pushed
the
upstream/test_cmac_caam_input_size
branch
from
3c82a08 to
baa500f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
@jforissier
The test to add is in the end very simple ... just one
XTEST_MAC_CMAC_CASE:)Should I specify in the commit message, that it's related to the CAAM? I don't know if I should since this test is generic and the CAAM platform specific ..
Please refer to OP-TEE/optee_os#4583
Thanks