Terraform validate var-file arg

[joe-dematteo]

Describe the bug

The terraform validate command is being passed the var-file arg.

To Reproduce

  - name: Terraform Action
    id: terraform-action
    uses: devsectop/tf-via-pr@v12.0.7
    with:
      command: "plan"
      plan-encrypt: ${{ secrets.PLAN_PASSPHRASE }}
      format: true
      validate: true
      comment-pr: recreate
      arg-var-file: "terraform.tfvars"

Expected behavior

The terraform validate command does not get passed the -var-file arg.

Additional context

Is the arg file supposed to be being passed to the Terraform validate command?

[rdhar]

Hey @joe-dematteo, great spot! It seems like you've hit upon our first Terraform vs OpenTofu discrepancy:

• As you've correctly identified, Terraform's validate does not support variable interpolation.
• Due to early-static-evaluation, OpenTofu's validate does support variable interpolation.

This makes resolution a bit tricky on our end. Ideally, we don't need/want to know which version you're running, and simply pass along whatever inputs are supplied. But it becomes necessary to intervene when command arguments conflict.

In the short-term, I'll see to adding a basic terraform/tofu check to determine whether or not to pass -var-file to validate command. In the longer term, I want to avoid maintaining some kind of table of feature in/compatibilities between versions for as long as possible!

As an aside, since you're running a plan, a validate isn't really strictly necessary. As the docs state, "use the terraform plan command instead, which includes an implied validation check."

[rdhar]

Happy to share this has been shipped with v12.0.8, where your contribution has been credited!

Please consider ⭐ this project, if you find it useful.