Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on depth estimation #157

Open
nicetryzz opened this issue May 8, 2024 · 3 comments
Open

Error on depth estimation #157

nicetryzz opened this issue May 8, 2024 · 3 comments

Comments

@nicetryzz
Copy link

I have test the KITTI-MOT 0006 Reconstruction config. The depth estimation is similar with the Wandb log provided. The estimated depth is different from the mono depth.
depth

@JiantengChen
Copy link
Collaborator

Hi! @nicetryzz

Thanks for your reply. Issue #92 might help. FYI.

@nicetryzz
Copy link
Author

Thanks for your quick replay. I think utilize the sky weight on depth loss calculation is a good idea.
By the way, I have two more questions:

  1. Does it reasonable to select rays from different images to calculate mono loss? Different image mono depth esitimate might have different scale and shift.
  2. I notice that scale_factor is set to 0.1. Also while calculate monosdf_depth_loss, a scale and shift is applied on termination_depth. Does it necessary?

@wuzirui
Copy link
Collaborator

wuzirui commented Sep 5, 2024

Hi @nicetryzz, for your questions:

  1. it is true that "select rays from different images to compute scale and shift" is not making too much sense for the monodepth, but overall the scale and shift is only an approximation to match monodepth with LiDAR depths. For the practical sake, this is enough because monodepths are mostly consistent in a sequence.
  2. I didn't get your questions sry. Could you elaborate more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants