Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sundials deprecated realtype in v7.0.0 #27

Open
alexander-novo opened this issue Sep 13, 2024 · 1 comment
Open

Sundials deprecated realtype in v7.0.0 #27

alexander-novo opened this issue Sep 13, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@alexander-novo
Copy link
Collaborator

https://github.com/LLNL/sundials/releases/tag/v7.0.0

The previously deprecated types realtype and booleantype were removed from sundials_types.h and replaced with sunrealtype and sunbooleantype. The deprecated names for these types can be used by including the header file sundials_types_deprecated.h but will be fully removed in the next major release. Functions, types and header files that were previously deprecated have also been removed.

Need to go in and change these to the new name sunbooleantype.

@pelesh
Copy link
Collaborator

pelesh commented Sep 16, 2024

I think we should move to SUNDIALS >= 7 dependency, I don't see a reason to stick with the older versions.

I don't think we are using realtype anywhere in the GridKit code. Since the real type is a template parameter, GridKit can use anything that is configured in SUNDIALS. However, when using multiple dependencies (Ipopt, SUNDIALS, KLU), it is users responsibility to ensure they are all built with the same real and index types.

@pelesh pelesh self-assigned this Oct 2, 2024
@pelesh pelesh added documentation Improvements or additions to documentation question Further information is requested labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants