Skip to content

Commit

Permalink
Merge pull request #81 from ORNL/dev
Browse files Browse the repository at this point in the history
Increasing notebook test timeout in all GH actions
  • Loading branch information
renan-souza authored Sep 20, 2023
2 parents 349bd76 + 82ea1d2 commit c8d4027
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/create-release-n-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,4 +104,4 @@ jobs:
run: |
python flowcept/flowcept_webserver/app.py &
sleep 3
pytest --nbmake "notebooks/" --ignore=notebooks/dask_from_CLI.ipynb
pytest --nbmake "notebooks/" --nbmake-timeout=600 --ignore=notebooks/dask_from_CLI.ipynb
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ jobs:
run: |
python flowcept/flowcept_webserver/app.py &
sleep 3
pytest --nbmake "notebooks/" --ignore=notebooks/dask_from_CLI.ipynb
pytest --nbmake "notebooks/" --nbmake-timeout=600 --ignore=notebooks/dask_from_CLI.ipynb
2 changes: 1 addition & 1 deletion .github/workflows/test-python-310.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ jobs:
run: |
python flowcept/flowcept_webserver/app.py &
sleep 3
pytest --nbmake "notebooks/" --ignore=notebooks/dask_from_CLI.ipynb
pytest --nbmake "notebooks/" --nbmake-timeout=600 --ignore=notebooks/dask_from_CLI.ipynb
2 changes: 1 addition & 1 deletion .github/workflows/test-python-39.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ jobs:
run: |
python flowcept/flowcept_webserver/app.py &
sleep 3
pytest --nbmake "notebooks/" --ignore=notebooks/dask_from_CLI.ipynb
pytest --nbmake "notebooks/" --nbmake-timeout=600 --ignore=notebooks/dask_from_CLI.ipynb
5 changes: 3 additions & 2 deletions tests/plugins/test_tensorboard.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,11 @@ def test_observer_and_consumption(self):
self._init_consumption()
wf_id = self.test_run_tensorboard_hparam_tuning()
self.logger.debug("Done training. Sleeping some time...")
TestTensorboard.consumer.stop()
watch_interval_sec = self.interceptor.settings.watch_interval_sec
# Making sure we'll wait until next watch cycle
sleep(watch_interval_sec * 7)
sleep(watch_interval_sec * 5)
TestTensorboard.consumer.stop()
sleep(watch_interval_sec * 5)
assert self.interceptor.state_manager.count() == 16
doc_dao = DocumentDBDao()
docs = doc_dao.query({"workflow_id": wf_id})
Expand Down

0 comments on commit c8d4027

Please sign in to comment.