From c9a1a17c5266f9c01da8be4daf4500aeafbb7ba7 Mon Sep 17 00:00:00 2001
From: ShubhamDesai <42180509+ShubhamDesai@users.noreply.github.com>
Date: Wed, 10 Jul 2024 20:11:20 -0400
Subject: [PATCH] i.segment: Fix uninitialized variable issue (#4023)

---
 imagery/i.segment/region_growing.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/imagery/i.segment/region_growing.c b/imagery/i.segment/region_growing.c
index f2c416b77de..dc5b5bd2157 100644
--- a/imagery/i.segment/region_growing.c
+++ b/imagery/i.segment/region_growing.c
@@ -696,7 +696,7 @@ static int find_best_neighbor(struct ngbr_stats *Ri, struct reg_stats *Ri_rs,
                               int clear_cand, struct globals *globals)
 {
     int n, n_ngbrs, no_check, cmp;
-    struct rc ngbr_rc, next, *pngbr_rc;
+    struct rc ngbr_rc = {0}, next = {0}, *pngbr_rc = NULL;
     struct rclist rilist;
     double tempsim;
     int neighbors[8][2];
@@ -893,7 +893,7 @@ double calculate_shape(struct reg_stats *rsi, struct reg_stats *rsk,
     double smooth, compact;
     int pl, pbbox, count;
     double bboxdiag;
-    int pl1, pl2, count1, count2;
+    int pl1 = 0, pl2 = 0, count1 = 0, count2 = 0;
     int e1, n1, s1, w1, e2, n2, s2, w2, ns_extent, ew_extent;
 
     pl = pl1 + pl2 - nshared;
@@ -989,7 +989,7 @@ static int search_neighbors(struct ngbr_stats *Ri, struct reg_stats *Ri_rs,
 int update_band_vals(int row, int col, struct reg_stats *rs,
                      struct globals *globals)
 {
-    struct rc next, ngbr_rc;
+    struct rc next = {0}, ngbr_rc = {0};
     int neighbors[8][2];
     int rid, count, n;
 
@@ -1498,7 +1498,7 @@ static int calculate_reg_stats(int row, int col, struct reg_stats *rs,
         ret = 1;
     else if (globals->min_reg_size == 3) {
         int n, rid;
-        struct rc ngbr_rc;
+        struct rc ngbr_rc = {0};
         int neighbors[8][2];
 
         globals->find_neighbors(row, col, neighbors);
@@ -1541,7 +1541,7 @@ static int calculate_reg_stats(int row, int col, struct reg_stats *rs,
         /* rs->id must be set */
         struct pavl_table *rc_check_tree; /* cells already checked */
         int n, rid;
-        struct rc ngbr_rc, *pngbr_rc, next;
+        struct rc ngbr_rc = {0}, *pngbr_rc = NULL, next = {0};
         struct rclist rilist;
         int neighbors[8][2];
         int no_check;