Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] winGRASS Version: 7.9.dev - g.extension: NameError: name 'branch' is not defined #1150

Closed
hellik opened this issue Dec 4, 2020 · 3 comments · Fixed by #1151
Closed
Assignees
Labels
bug Something isn't working windows Microsoft Windows specific
Milestone

Comments

@hellik
Copy link
Member

hellik commented Dec 4, 2020

Describe the bug

winGRASS Version: 7.9.dev - g.extension: NameError: name 'branch' is not defined


g.extension extension=r.sample.category                                         
Downloading precompiled GRASS Addons <r.sample.category>...
Traceback (most recent call last):
  File
"C:\OSGEO4~1\apps\grass\grass79/scripts/g.extension.py",
line 2343, in <module>
    sys.exit(main())
  File
"C:\OSGEO4~1\apps\grass\grass79/scripts/g.extension.py",
line 2323, in main
    install_extension(source=source, url=url, xmlurl=xmlurl,
branch=branch)
  File
"C:\OSGEO4~1\apps\grass\grass79/scripts/g.extension.py",
line 871, in install_extension
    ret1, new_modules_ext, new_files_ext =
install_extension_win(extension)
  File
"C:\OSGEO4~1\apps\grass\grass79/scripts/g.extension.py",
line 1236, in install_extension_win
    branch=branch)
NameError: name 'branch' is not defined

maybe related to the recent changes in g.extension in master?

To Reproduce
Steps to reproduce the behavior:

  1. start winGRASS Version: 7.9.dev Code revision: 47579af
  2. in g.extension GUI try to download an addon

System description (please complete the following information):

GRASS Version: 7.9.dev                                                          
Code revision: 47579afce                                                        
Build date: 2020-12-03                                                          
Build platform: x86_64-w64-mingw32                                              
GDAL: 3.1.4                                                                     
PROJ: 6.3.2                                                                     
GEOS: 3.8.1                                                                     
SQLite: 3.29.0                                                                  
Python: 3.7.0                                                                   
wxPython: 4.0.7                                                                 
Platform: Windows-10-10.0.19041-SP0 (OSGeo4W) 
@hellik hellik added bug Something isn't working windows Microsoft Windows specific labels Dec 4, 2020
@ninsbl
Copy link
Member

ninsbl commented Dec 4, 2020

Yes. Sorry. My fault. Will look into this ASAP.

@ninsbl
Copy link
Member

ninsbl commented Dec 5, 2020

Sorry for the glitch. Does not seem to be covered by tests.... In the PR I documented how I tested the Windows specific function on my linux box in Python.

@hellik
Copy link
Member Author

hellik commented Dec 6, 2020

#1151 should fix the issue. waiting for merging and backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows Microsoft Windows specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants