-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fix PDAL support for OSGeo4W #1821
Comments
It just means compilation and linking to PDAL library has failed: Line 1020 in 9f853f0
Actual error is visible in the configure.log file. Content of that file might help to shed some light into the issue. As usual – if Windows users need PDAL support in GRASS, one of Windows users must step up and fix the issue. I could look into the issue if a link to a VM image with suitable environment is provided. |
Fair enough. Here: https://github.com/ninsbl/grass/runs/3412192862?check_suite_focus=true is at least the config.log |
Could you, please, provide the output of following commands:
|
Thanks for bearing with me here, @marisn The content for pdal-config in OSGeo4W is here: It seems that the returned With that change first winsock2.h is not found, and after adding the location of winsock2.h to the includepath for c++ configuration proceeds a bit further, but then fails to find Latest configure log is here: And yes, I guess PDAL is compiled with MSVC. Here is the OSGeo4W build script: |
This likely depends on: #348 |
Describe the bug
OSGeo4W ships PDAL version 2.3.
When PDAL support is activated for OSGeo4W with a path to pdal-config, pdal-config is found, but GRASS complains that the PDAL library is not suitable
Unable to locate suitable (>=1.7.1) PDAL library
.To Reproduce
See: https://github.com/ninsbl/grass/runs/3408602894?check_suite_focus=true
Expected behavior
It is important to have PDAL support on MS Windows too, so GRASS should be compiled with PDAL support on MS Windows as well.
Would be great to have that working for 8.0 but I set the 8.2 milestone. Feel free to change if feasible to get it into 8.0...
System description (please complete the following information):
GRASS OSGeo4W CI
GRASS GIS version 7.9 / 8.0 preview
Additional context
Here is how the PDAL packages for OSGeo4W are built:
https://github.com/jef-n/OSGeo4W/blob/master/src/pdal/osgeo4w/package.sh
The text was updated successfully, but these errors were encountered: