You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Test fails with option <profiledata> requires <coordinates> because there is confusion about optional parameters with default values. This seems to be more an issue with to pygrass and GUI than with r.geomorphon or parser according to analysis by @infrastation and others.
History (in r.info) and pygrass Module fill in the defaults (so profiledata="-" profileformat="json" is put there). However, when such command is executed, it fails with:
This happened only after I suggested to @infrastation to use the automated check declaration instead of a manual checks. For r.geomorphon, the solution is either going back to the manual check or not providing defaults which may actually make sense in this case. However, it seems that the issue is in pygrass and the same issue happens to be in GUI too. Maybe the parser can be modified because the defaults are sometimes recorded even when not used (for history), but it seems to me now that the first issue is that the Python code (both GUI and independently pygrass) is mishandling the defaults.
It might help to add a few paragraphs to gislib_cmdline_parsing.html to define more precisely what "default" and "optional" means; and only then to eliminate discrepancies in the offending plugins and parts of the API.
Test fails with
option <profiledata> requires <coordinates>
because there is confusion about optional parameters with default values. This seems to be more an issue with to pygrass and GUI than with r.geomorphon or parser according to analysis by @infrastation and others.History (in r.info) and pygrass Module fill in the defaults (so
profiledata="-" profileformat="json" is put there
). However, when such command is executed, it fails with:This happened only after I suggested to @infrastation to use the automated check declaration instead of a manual checks. For r.geomorphon, the solution is either going back to the manual check or not providing defaults which may actually make sense in this case. However, it seems that the issue is in pygrass and the same issue happens to be in GUI too. Maybe the parser can be modified because the defaults are sometimes recorded even when not used (for history), but it seems to me now that the first issue is that the Python code (both GUI and independently pygrass) is mishandling the defaults.
Originally posted by @wenzeslaus in #1157 (comment). See also the following comments there.
The text was updated successfully, but these errors were encountered: