-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] CI: add support for [skip ci] #2174
Comments
Why not use Instead of having a system when the contributor needs to carefully decide, |
Ah, I wasn't aware of that possibility.
Sounds good. I'll make a new attempt. Best would be to save these ignore-paths to a single file rather than replicating them in all workflows. Would that be possible? |
See new PR #2176 |
I think we should start to use this as soon as possible. https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs |
I don't know how well the skip would work, the concurrency config for workflows seemed more hopeful, maybe combined with running specific checks for specific files. |
Well, technically, skipping ci completely works natively since February 2021, I tested it in my fork just now, and none of the workflow was run, just like that blog post announcing it describes: Knowing this, what exactly is the purpose of this issue? There are already some path filtering done in our workflows, like the docker one, and skipping CI works natively. What is missing? |
Nice, seems nobody ever tried it out so far. |
I think this is resolved and being resolved by faster workflows, so I'm closing this. For skip itself, I would advice caution with
Importantly, the GitHub feature is mainly useful for skipping checks when pushing a lot of small or anyway unchecked changes to a PR branch, i.e., in a "sandbox" of a PR. (This is different from the idea in the OP where contributors needs to carefully decide about the nature of the changes even for merge to main.) |
Is your feature request related to a problem? Please describe.
At time the full CI is run even when only
doc/howto_release.md
is edited which does not require CI checks at all.This is a waste of runner resources.
Describe the solution you'd like
Like in the GDAL repo, add support for
[skip ci]
or[ci skip]
.Note: Once implemented, the contributor needs to carefully decide if their PR submission may skip CI or not (it will rather be an exception to skip it).
The text was updated successfully, but these errors were encountered: