Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Changing map layer opacity level via map layer opacity dialog fail when 3d view is activated #2696

Closed
tmszi opened this issue Dec 13, 2022 · 0 comments · Fixed by #2697
Labels
bug Something isn't working GUI wxGUI related
Milestone

Comments

@tmszi
Copy link
Member

tmszi commented Dec 13, 2022

Describe the bug
Changing map layer opacity level via map layer opacity dialog fail when 3D view is activated.

To Reproduce
Steps to reproduce the behavior:

  1. Launch wxGUI
  2. Display some raster map e.g. d.rast elevation
  3. Switch from the 2D view to the 3D view
  4. Right mouse click on the elevation raster map layer to invoke layer menu
  5. From the layer menu choose "Change opacity level to launch dialog"
  6. Change opacity level for raster map layer and hit Apply or Ok button
  7. See error
Traceback (most recent call last):
  File
"/usr/lib64/grass83/gui/wxpython/gui_core/dialogs.py", line
1885, in OnApply

self.applyOpacity.emit(value=self.GetOpacity())
  File
"/usr/lib64/grass83/etc/python/grass/pydispatch/signal.py",
line 233, in emit

dispatcher.send(signal=self, *args, **kwargs)
  File "/usr/lib64/grass83/etc/python/grass/pydispatch/dispa
tcher.py", line 344, in send

response = robustapply.robustApply(
  File "/usr/lib64/grass83/etc/python/grass/pydispatch/robus
tapply.py", line 60, in robustApply

return receiver(*arguments, **named)
  File "/usr/lib64/grass83/gui/wxpython/lmgr/layertree.py",
line 1205, in <lambda>

lambda value: self.ChangeLayerOpacity(
  File "/usr/lib64/grass83/gui/wxpython/lmgr/layertree.py",
line 1243, in ChangeLayerOpacity

self.GetMapDisplay().GetWindow().UpdateMap(
TypeError
:
UpdateMap() got an unexpected keyword argument
'renderVector'

Expected behavior
We don't need show layer opacity dialog when 3D view is activated for map layer, because map layer opacity level in the 3d view is changed via 3D view pane -> Data page (tab) -> Surface attributes -> Transparency setting.

System description:

  • Operating System: all
  • GRASS GIS version: all
@tmszi tmszi added bug Something isn't working GUI wxGUI related labels Dec 13, 2022
@tmszi tmszi added this to the 8.3.0 milestone Dec 13, 2022
@neteler neteler modified the milestones: 8.3.0, 8.2.1 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants