Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preprocess module does not have tests against "real" data. #454

Closed
lsetiawan opened this issue Oct 11, 2021 · 2 comments · Fixed by #487
Closed

Preprocess module does not have tests against "real" data. #454

lsetiawan opened this issue Oct 11, 2021 · 2 comments · Fixed by #487
Assignees
@lsetiawan @imranmaj
Milestone
0.5.5 release

Comments

@lsetiawan
Copy link
Member

Currently, the preprocess module is not tested against any "real" data. Tests against toy data can be found at https://github.com/OSOceanAcoustics/echopype/blob/main/echopype/tests/old/test_preprocess.py.
@leewujung leewujung added this to the 0.5.5 release milestone Oct 25, 2021
@leewujung
Copy link
Member

It is kinda bizarre that test_preprocess.py is under tests/old!
Shouldn't it be under tests/preprocess?
I guess this calls for a PR to both add tests running on real data and fix the folder structure.

@lsetiawan lsetiawan self-assigned this Nov 4, 2021
@lsetiawan lsetiawan moved this to Todo in Echopype Nov 4, 2021
@lsetiawan lsetiawan assigned imranmaj and unassigned imranmaj Nov 4, 2021
@lsetiawan lsetiawan mentioned this issue Nov 11, 2021
Merged
@lsetiawan lsetiawan linked a pull request Nov 11, 2021 that will close this issue
Move preprocess test and test against "real" data; perform a little cleanup. #487
Merged
@lsetiawan lsetiawan moved this from Todo to In Progress in Echopype Nov 11, 2021
@leewujung
Copy link
Member

Addressed in #487.

Repository owner moved this from In Progress to Done in Echopype Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsetiawan lsetiawan

@imranmaj imranmaj

Labels
None yet
Projects
Echopype
Archived in project
Milestone
0.5.5 release
Development

Successfully merging a pull request may close this issue.

Move preprocess test and test against "real" data; perform a little cleanup. lsetiawan/echopype
3 participants
@leewujung @lsetiawan @imranmaj