Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xarray accessor to implement dataset-centric approach #86

Closed
ldr426 opened this issue Jun 2, 2023 · 1 comment
Closed

Use xarray accessor to implement dataset-centric approach #86

ldr426 opened this issue Jun 2, 2023 · 1 comment
Labels
feature request New feature or request

Comments

@ldr426
Copy link
Collaborator

ldr426 commented Jun 2, 2023

In order to improve the visualization and interactivity of echogram data, I propose implementing a dataset-centric approach using xarray accessor and leveraging the capabilities of HoloViews. This approach would enable users to manipulate and view echogram data with increased flexibility and customization.

Expected Behavior:

  1. Implement an xarray accessor for echogram data, allowing users to access and manipulate the data in a dataset-centric manner.
  2. Create methods, like ds.echoshader.view_echogram(), that combines the different components of the echogram visualization (e.g., image, colormap selector, box selection) into a single, customizable layout.
  3. Feature like the ds.echoshader.view_echogram() method should accept parameters such as the colormap to be used, with a default value provided (e.g., cmap="jet").
  4. Separate out the individual components like follows:
  • ds_echogram = ds.echoshader.echogram() - Generate the echogram image component.
  • cmapsel = ds.echoshader.colormap_selector() - Provide a colormap selector component for customizing the color map.
  • boxsel = ds.echoshader.get_box() - Include a box selection component for highlighting specific areas of interest.
  1. Integrate the HoloViews library to enhance the interactive capabilities of the echogram visualization, leveraging features such as linking plots and widgets.

Use xarray accessor: https://docs.xarray.dev/en/stable/internals/extending-xarray.html
https://holoviews.org/user_guide/Linking_Plots.html

@ldr426 ldr426 added the feature request New feature or request label Jun 2, 2023
@ldr426 ldr426 added this to the Refactoring echoshader milestone Jun 2, 2023
@ldr426 ldr426 added this to Echoshader Jun 2, 2023
@ldr426
Copy link
Collaborator Author

ldr426 commented Aug 10, 2023

Has been built in #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant