Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detach echograms linking between different examples #99

Closed
ldr426 opened this issue Jun 15, 2023 · 2 comments
Closed

Detach echograms linking between different examples #99

ldr426 opened this issue Jun 15, 2023 · 2 comments
Labels
bug Something isn't working
Milestone
Refactoring echos...

Comments

@ldr426
Copy link
Collaborator

ldr426 commented Jun 15, 2023

Single frequency and multiple frequency plots are linked, but tricolor is not: maybe best not to link them since they are three different examples, not one widget.

Originally posted by @valentina-s in #93 (comment)
@ldr426 ldr426 added the bug Something isn't working label Jun 15, 2023
@leewujung leewujung added this to the Refactoring echoshader milestone Jun 30, 2023
@leewujung
Copy link
Member

I think that different layouts should just be different widgets, and we can provide example notebooks to show people how to link them?

@ldr426
Copy link
Collaborator Author

ldr426 commented Aug 10, 2023

Has designed the pattern that unifed all echograms(including tricolor echogram) behaviors in #13

@ldr426 ldr426 closed this as completed Aug 10, 2023
@ldr426 ldr426 mentioned this issue Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Echoshader
Status: Done
Milestone
Refactoring echoshader (first release)
Development

No branches or pull requests
2 participants
@leewujung @ldr426