Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL certificate problem #56

Closed
sheetlaand opened this issue Mar 30, 2022 · 3 comments · Fixed by #73
Closed

SSL certificate problem #56

sheetlaand opened this issue Mar 30, 2022 · 3 comments · Fixed by #73
Labels
enhancement New feature or request

Comments

@sheetlaand
Copy link

Hey Roberto,

I'm currently facing an SSL certificate error while I'm trying to communicate with the TAXII server. Knowing that I encounter this problem when I am behind my corporate proxy, I think this problem could be solved by offering the user the possibility not to block the communication when an insecure certificate is encountered.

For example, I find the following error when I launch a cURL command line on the TAXII server:
curl -H "Accept: application/vnd.oasis.taxii+json" https://cti-taxii.mitre.org/taxii/
curl: (60) SSL certificate problem: unable to get local issuer certificate More details here: https://curl.haxx.se/docs/sslcerts.html curl failed to verify the legitimacy of the server and therefore could not establish a secure connection to it. To learn more about this situation and how to fix it, please visit the web page mentioned above.

If I just add a -k parameter to the same cURL command line:
curl -H "Accept: application/vnd.oasis.taxii+json" https://cti-taxii.mitre.org/taxii/ -k
{"title":"CTI TAXII server","description":"This TAXII server contains a listing of ATT&CK domain collections expressed as STIX, including PRE-ATT&CK, ATT&CK for Enterprise, and ATT&CK Mobile.","contact":"attack@mitre.org","default":"https://cti-taxii.mitre.org/stix/","api_roots":["https://cti-taxii.mitre.org/stix/"]}

I hope that my problem is clear enough, and I hope that a solution can be found.
Best regards,

@Cyb3rWard0g
Copy link
Collaborator

Hello @sheetlaand !

I wonder if the verify method would work in TAXIIClient . I believe this is the same issue right? oasis-open/cti-taxii-client#24

@sheetlaand
Copy link
Author

Yeah, probably the same issue.

I tried to add a "verify=False" attribute to the Collection classes in the "attack_api.py" file (line 53 to 56), it works !

However, I think there must be a more conventional way to do this, do you have a coherent solution for me?
Maybe since MITRE's attack certificate is issued by MITRE's internal certificate authority (oasis-open/cti-taxii-client#33), I just need to use the "verify=False" setting when I am behind my company's proxy.

@Cyb3rWard0g
Copy link
Collaborator

Glad to hear the verify=False thing worked. I believe that should be the way how this should be handled. However, it needs to be added to the library itself so that the parameter can be used across all functions. Would that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants