Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new nvram_test to macOS schema #103

Closed
solind opened this issue Jun 18, 2020 · 2 comments
Closed

Add new nvram_test to macOS schema #103

solind opened this issue Jun 18, 2020 · 2 comments
Labels
Existing Schema Update A proposal for update(s) to an existing OVAL Test/Object/State MacOS Issue related to the Mac schema.
Milestone

Comments

@solind
Copy link

solind commented Jun 18, 2020

Abstract
I have recently discovered that there is at least one important nvram property key that is not included in the scope of properties enumerated by the nvram -p command. Therefore, we need to clarify the documentation on this test, to indicate that we will use only nvram -p expressed properties when operations other than "equals" are indicated in the object, but that the interpreter should attempt to retrieve any other specified key if the "equals" operator is indicated.

Additionally, I have discovered that nvram values are stored primitively as binary (NSData) plist data. Therefore we should probably really be using an Entity[State/Item]BinaryType instead of the String type to store this data. This would require a new nvram512_test/object/state.

Link to Proposal
PR to come.

Additional context
See attached sample content for the new nvram512 binary test.

content.zip

solind pushed a commit to solind/OVAL that referenced this issue Jun 18, 2020
@wmunyan wmunyan added Existing Schema Update A proposal for update(s) to an existing OVAL Test/Object/State MacOS Issue related to the Mac schema. labels Aug 6, 2020
@wmunyan wmunyan added this to the 5.12 milestone Aug 6, 2020
@wmunyan
Copy link
Contributor

wmunyan commented Aug 7, 2020

No objections to this one.

solind pushed a commit that referenced this issue Sep 3, 2020
Pull request for MacOS Issues: #19, #52, #84, #95, #99, #100, #101, #102, #103, #104, #105 and #106.
@solind
Copy link
Author

solind commented Sep 3, 2020

a5ae8d7

@solind solind closed this as completed Sep 3, 2020
@vanderpol vanderpol changed the title macos:nvram_test enhancements Add new nvram_test to macOS schema Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Existing Schema Update A proposal for update(s) to an existing OVAL Test/Object/State MacOS Issue related to the Mac schema.
Projects
None yet
Development

No branches or pull requests

2 participants